Skip to content

[16.0][FIX] remove nested loop in tax reports#135

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
coopiteasy:16.0-fix-tax-reports-nested-loop
Jan 13, 2026
Merged

[16.0][FIX] remove nested loop in tax reports#135
OCA-git-bot merged 1 commit intoOCA:16.0from
coopiteasy:16.0-fix-tax-reports-nested-loop

Conversation

@huguesdk
Copy link
Copy Markdown
Member

@huguesdk huguesdk commented Apr 9, 2025

remove the nested loop in the donation tax report template to ensure that each record is present once in the generated report instead of the number of records squared when generating a report for multiple records.

remove the nested loop in the donation tax report template to ensure
that each record is present once in the generated report instead of the
number of records squared when generating a report for multiple records.
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

Copy link
Copy Markdown

@remytms remytms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@huguesdk
Copy link
Copy Markdown
Member Author

huguesdk commented Jul 9, 2025

@OCA/donation-maintainers would someone please merge this?

Copy link
Copy Markdown

@yweng8111 yweng8111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution

makayabou added a commit to makayabou/donation that referenced this pull request Jul 10, 2025
@mkanderson
Copy link
Copy Markdown

@OCA/donation-maintainers 👋

This PR looks ready (2 approvals + approved label), but it’s blocked because the required runboat/build check never appeared under “Checks” on GitHub. The PR shows “Waiting for status to be reported” indefinitely.

It seems Runboat didn’t create a build for this PR (no runboat/build line under checks, only the branch build is visible). Could you please retrigger the Runboat build or adjust the required check so this can be merged?

Thanks 🙏

@huguesdk
Copy link
Copy Markdown
Member Author

huguesdk commented Oct 3, 2025

@mkanderson afaik, the runboat build it not required for the pr to be mergeable. all that is needed is that a maintainer or psc member triggers the merge.

@alexis-via
Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-135-by-alexis-via-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 293586c into OCA:16.0 Jan 13, 2026
6 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 91a7515. Thanks a lot for contributing to OCA. ❤️

@remytms
Copy link
Copy Markdown

remytms commented Jan 14, 2026

Thanks @alexis-via

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants