Skip to content

[18.0][IMP] product_contract - add class o_row to auto_renew fields#1318

Open
anthonissen-a wants to merge 1 commit intoOCA:18.0from
acsone:18.0-product_contract_add_o_row-aan
Open

[18.0][IMP] product_contract - add class o_row to auto_renew fields#1318
anthonissen-a wants to merge 1 commit intoOCA:18.0from
acsone:18.0-product_contract_add_o_row-aan

Conversation

@anthonissen-a
Copy link
Copy Markdown

Added class="o_row" to the auto-renew divs to ensure consistent layout and styling with the recurrence section.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

@anthonissen-a anthonissen-a changed the title [IMP] product_contract - add class o_row to auto_renew fields [18.0][IMP] product_contract - add class o_row to auto_renew fields Oct 17, 2025
Copy link
Copy Markdown
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @anthonissen-a
At the code level, I understand that this improvement adds consistency in layout and styling with the recurrence section, but visually I can't see any changes. In any case, I believe this is the correct way the code should be.

@anthonissen-a
Copy link
Copy Markdown
Author

Hi @mamcode, thanks for the review! In one of our projects, I had to make these fields readonly, and that's where the styling difference becomes noticeable. You can see the contrast in the screenshots below, with and without class="o_row" applied :

image image

@mamcode
Copy link
Copy Markdown
Member

mamcode commented Oct 20, 2025

@anthonissen-a Thanks, now it's clear to me.

Copy link
Copy Markdown
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems consistant with the rest of the module. (I wonder what happens on the responsivness though)

@yvaucher
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1318-by-yvaucher-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 26, 2026
Signed-off-by yvaucher
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1318-by-yvaucher-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants