[18.0][IMP] product_contract - add class o_row to auto_renew fields#1318
[18.0][IMP] product_contract - add class o_row to auto_renew fields#1318anthonissen-a wants to merge 1 commit intoOCA:18.0from
Conversation
|
Hi @sbejaoui, |
mamcode
left a comment
There was a problem hiding this comment.
Thanks for this improvement @anthonissen-a
At the code level, I understand that this improvement adds consistency in layout and styling with the recurrence section, but visually I can't see any changes. In any case, I believe this is the correct way the code should be.
|
Hi @mamcode, thanks for the review! In one of our projects, I had to make these fields readonly, and that's where the styling difference becomes noticeable. You can see the contrast in the screenshots below, with and without
|
|
@anthonissen-a Thanks, now it's clear to me. |
yvaucher
left a comment
There was a problem hiding this comment.
Seems consistant with the rest of the module. (I wonder what happens on the responsivness though)
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1318-by-yvaucher-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |


Added
class="o_row"to the auto-renew divs to ensure consistent layout and styling with the recurrence section.