Open
Conversation
edescalona
force-pushed
the
17.0-add-connector_importer_api
branch
2 times, most recently
from
655af83 to
c83b29f
Compare
Author
|
Ready for review |
edescalona
force-pushed
the
17.0-add-connector_importer_api
branch
from
c83b29f to
e52ca44
Compare
edescalona
force-pushed
the
17.0-add-connector_importer_api
branch
4 times, most recently
from
1fdf31b to
a212344
Compare
[FIX] connector_importer_api: Resolve conflict [IMP] connector_importer_api: Change name file views. Edit import source api [IMP] onnector_importer_api: Generate parameter values dynamically.
edescalona
force-pushed
the
17.0-add-connector_importer_api
branch
from
a212344 to
ae5b01c
Compare
adasatorres
added a commit
to BinhexTeam/connector-interfaces
that referenced
this pull request
Jul 21, 2025
adasatorres
suggested changes
Jul 24, 2025
| enviroment_url = fields.Char(string="Enviroment URL", required=True) | ||
| type_request = fields.Selection( | ||
| string="Request type", | ||
| selection=[("get", "GET")], |
There was a problem hiding this comment.
Why not include the POST method as one of the options for the type_request field?
Suggested change
| selection=[("get", "GET")], | |
| selection=[("get", "GET"), ("post", "POST")], |
Author
There was a problem hiding this comment.
Hi @adasatorres , thanks for your comments. Initially, the POST type was not added because it was not necessary for the initial requirement, but it can still be extended and all possible types can be added and the necessary configurations made.
adasatorres
added a commit
to BinhexTeam/connector-interfaces
that referenced
this pull request
Jul 24, 2025
simahawk
reviewed
Nov 25, 2025
| from odoo.addons.component.core import Component | ||
|
|
||
|
|
||
| class Tracker(Component): |
Contributor
There was a problem hiding this comment.
what is the purpose of this override?
Contributor
|
I'm not sure to understand how this is supposed to work. Also, you say "token" everywhere but is not clear what it should represent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@BinhexTeam
A new source has been added for API use.
Main features: