[FIX] don't traceback when origin is not filled#1238
Open
thomaspaulb wants to merge 1 commit intoOCA:14.0from
Open
[FIX] don't traceback when origin is not filled#1238thomaspaulb wants to merge 1 commit intoOCA:14.0from
thomaspaulb wants to merge 1 commit intoOCA:14.0from
Conversation
In some cases, orderpoint_id is filled but origin is not. I have no idea which exact flows lead to this, but I notice it is fixed in future Odoo versions as part of odoo/pull/80319. I'm not sure about backporting all of that, but at least this part is IMO harmless to just merge in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
In some cases, orderpoint_id is filled but origin is not. I have no idea which exact flows lead to this, but I notice it is fixed in future Odoo versions as part of odoo/pull/80319. I'm not sure about backporting all of that, but at least this part is IMO harmless to just merge in.
Current behavior before PR:
Upon confirming an MO with
orderpoint_idbut noorigin:Desired behavior after PR is merged:
No traceback, MO confirms OK
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr