Added overview-imports.md first draft and image#538
Merged
matentzn merged 4 commits intoOBOAcademy:masterfrom Apr 17, 2026
Merged
Added overview-imports.md first draft and image#538matentzn merged 4 commits intoOBOAcademy:masterfrom
matentzn merged 4 commits intoOBOAcademy:masterfrom
Conversation
matentzn
reviewed
Apr 7, 2025
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
I love this; as this will be cited as "best practice" I will asks some more eyes on this.
|
|
||
| There may be a case when you have imported a term using SLME or MIREOT where you find a need to add an axiom. If that happens, the best practice is to try to make an issue or PR with the originating ontology to get the axiom added. | ||
|
|
||
| If more urgent action is required, or there are difficulties with that process, a less preferrable but viable alternative is to add an annotation property **on the new axiom** that clearly states the axiom has been added in your ontology and is not in the original ontology. |
Collaborator
There was a problem hiding this comment.
This is called "axiom injection". I would add a comment that such axioms should not not be included in the "base release" of a domain ontology.
Collaborator
There was a problem hiding this comment.
Collaborator
|
@timalamenciak do we want to wrap this up so it can be available on OBO Academy? |
Collaborator
|
@timalamenciak friendly ping! Any comments on the feedback? |
Contributor
Author
Oh man! Thanks for the reminder. I've addressed the comment. Hopefully all is good now. |
matentzn
approved these changes
Apr 17, 2026
Collaborator
|
Thank you @timalamenciak ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of a How-to overview on importing terms. I am sure that I got some stuff wrong and welcome feedback!