Add OpenSearch description#336
Conversation
|
I am wondering whether we should add a separate one for the packages and options search part? |
|
Also the endpoint probably should be on /packages or /options and not just on / |
|
Also the actual title would be included. |
|
Good point. I agree the OpenSearch entry should likely be split so packages and options can have their own targets instead of one generic root link. I will adjust the implementation in that direction unless you prefer a different shape. |
Signed-off-by: Markus Stark <markusstark@MacBook-Air-von-Markus.local>
|
Implemented the OpenSearch update: the PR now exposes separate OpenSearch descriptions for packages and options instead of one generic description. |
|
Don't we manually want to include the opensearch.xml of the current search type dynamically. (options vs packages.) Also this is till open: I mean the title from the config
|
|
@MarcelCoding Implemented the follow-up: the OpenSearch link is now selected dynamically for the active search type ( |
|
I would move it into the comments that are rendered by the router. Then we don't need to handle the router events ourself. |
MarcelCoding
left a comment
There was a problem hiding this comment.
But let's wait for the preview deployment.
|
The compiler is not happy yet. |
|
Fixed the TS4111 compiler issue by switching the dataset access to bracket notation. The branch is pushed again, so CI should rerun on the updated commit. |
|
Did you manage to test this behavior locally? If I am on GitHub and type something in the URL bar in Firefox, there is an entry "search with github". If I to the same with a local version of the search, it's missing. |
|
I checked this locally just now: the OpenSearch link is correctly injected into the page head on both routes. |
|
@MarcelCoding I also pushed a small follow-up for the failing Pages workflow on this branch. The parse error came from using |
That already was it from the beginning. But the browser does not interpret it for me. Maybe its an issue with localhost or, because its inserted using javascript and being present from the beginning in the index.html? |
Adds an OpenSearch description file and links it from the document head so browsers can discover the search endpoint more easily. Addresses #154.