Skip to content

Update for NPE 5 (WIP) + Configure Azure Pipeline#2

Closed
304NotModified wants to merge 4 commits intomasterfrom
npe5
Closed

Update for NPE 5 (WIP) + Configure Azure Pipeline#2
304NotModified wants to merge 4 commits intomasterfrom
npe5

Conversation

@304NotModified
Copy link
Copy Markdown

@304NotModified 304NotModified commented Aug 3, 2019

Update for NPE 5

image

image

@304NotModified
Copy link
Copy Markdown
Author

uses local package (Types)

@304NotModified 304NotModified changed the title Update for NPE (WIP) Update for NPE 5 (WIP) Aug 3, 2019
@304NotModified
Copy link
Copy Markdown
Author

Guess supersedes #1

<Reference Include="System.Data" />
<Reference Include="System.Xml" />
<Reference Include="WindowsBase" />
<PackageReference Include="NuGetPackageExplorer.Types" Version="5.2.15-1c821c59ad" />
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this one on nuget.org

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't easily since it references a private copy of NuGet currently.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see <PackageReference Include="NuGet.Packaging" Version="5.3.0-xprivate.60008" />, how could I restore that one on my machine?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm eventually going to move them to a feed on Azure Artifacts now that they support public feeds.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, The extension is using 5.2.0-xprivate

image

@304NotModified
Copy link
Copy Markdown
Author

@onovotny I think I gonna merge this, as the master is even not compiling. OK with you?

@clairernovotny
Copy link
Copy Markdown
Member

We can get a pipeline yaml setup for this

@304NotModified
Copy link
Copy Markdown
Author

Do you mean we should setup appveyor?

@clairernovotny
Copy link
Copy Markdown
Member

I haven't built out the script yet, but this one is wired up to Pipelines:
https://github.com/NuGetPackageExplorer/Extensions.IlSpy/blob/master/azure-pipelines.yml

@304NotModified 304NotModified changed the title Update for NPE 5 (WIP) Update for NPE 5 (WIP) + Configure Azure Pipeline Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants