Change protected overload of PackageManager.InstallPackage to be public#61
Open
glennblock wants to merge 2 commits intoNuGet:2.13from
Open
Change protected overload of PackageManager.InstallPackage to be public#61glennblock wants to merge 2 commits intoNuGet:2.13from
glennblock wants to merge 2 commits intoNuGet:2.13from
Conversation
|
Hi @glennblock, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@glennblock, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scriptcs relies on NuGet.Core. We started having issues recently as whenever we installed NuGet Packages that also support .NET Standard / .NET Core, we started getting all the core packages, even though they are not needed.
Looking through the code I noticed that
targetFrameworkis always forced to null in the publicInstallPackageoverloads. This meant I had to create my own derivedPackageManagerclass just to expose the protected overload. You can see I did that here. For users of NuGet.Core, I'd argue it's reasonable for them to be able to force the target version without having to derive.