Skip to content

add try catch #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RemyNovactive wants to merge 5 commits into
base: master-4.x
Choose a base branch
from
Open

add try catch #129

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd0f3d2
add try catch
Jan 24, 2022
65541e4
add log
Jan 24, 2022
4400d41
change try catch location
Jan 24, 2022
874658b
clean PR
Jan 24, 2022
ceb4948
Symplify CQN
Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions bundle/Twig/NovaeZSEOExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
use eZ\Publish\API\Repository\Values\Content\ContentInfo;
use eZ\Publish\API\Repository\Values\Content\Field;
use eZ\Publish\API\Repository\Values\ContentType\ContentType;
use eZ\Publish\Core\Base\Exceptions\NotFoundException;
use eZ\Publish\Core\Base\Exceptions\UnauthorizedException;
use eZ\Publish\Core\MVC\ConfigResolverInterface;
use eZ\Publish\Core\MVC\Symfony\Locale\LocaleConverter;
use Novactive\Bundle\eZSEOBundle\Core\CustomFallbackInterface;
Expand Down Expand Up @@ -63,6 +65,11 @@ class NovaeZSEOExtension extends AbstractExtension implements GlobalsInterface
*/
protected $customFallBackService;

/**
* @var LoggerInterface|null
*/
protected $logger;

public function __construct(
Repository $repository,
MetaNameSchema $nameSchema,
Expand All @@ -75,6 +82,14 @@ public function __construct(
$this->localeConverter = $localeConverter;
}

/**
* @required
*/
public function setLogger(LoggerInterface $logger): void
{
$this->logger = $logger;
}

public function setCustomFallbackService(CustomFallbackInterface $service)
{
$this->customFallBackService = $service;
Expand Down Expand Up @@ -178,8 +193,17 @@ protected function innerComputeMetas(
$meta->setContent($configuration[$meta->getName()]);
}
}
if (!$this->metaNameSchema->resolveMeta($meta, $content, $contentType)) {
$needFallback = true;
try {
if (!$this->metaNameSchema->resolveMeta($meta, $content, $contentType)) {
$needFallback = true;
}
} catch (NotFoundException|UnauthorizedException $exception) {
if ($this->logger) {
$this->logger->error('[Nova eZ SEO] Error when resolving meta', [
'message' => $exception->getMessage(),
'contentId' => $content->id,
]);
}
}
}

Expand Down