✨(approvals): make dangerous command approval timeout configurable#3766
Closed
acsezen wants to merge 1 commit intoNousResearch:mainfrom
Closed
✨(approvals): make dangerous command approval timeout configurable#3766acsezen wants to merge 1 commit intoNousResearch:mainfrom
acsezen wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Read `approvals.timeout` from config.yaml (default 60s) instead of hardcoding 60 seconds in both the fallback CLI prompt and the TUI prompt_toolkit callback. Follows the same pattern as `clarify.timeout` which is already configurable via CLI_CONFIG. Closes NousResearch#3765
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approvals.timeoutfromconfig.yamlinstead of hardcoding 60 secondstools/approval.py) and the TUI prompt_toolkit callback (hermes_cli/callbacks.py)Motivation
When running complex agent workflows with delegation subtasks, the 60s timeout is often too short — the prompt expires and the command is denied before the user can respond. The
clarifycallback already reads its timeout from config, so this follows the same pattern.Test plan
test_approval.py+test_cli_approval_ui.py)approvals.timeout: 10and verify the countdown matchesapprovals.timeoutand verify 60s defaultCloses #3765