fix: reject empty holdout datasets#59
Closed
steezkelly wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this PR in favor of consolidated PR #68. Local integration found real helper-block overlap in evolution/skills/evolve_skill.py across the stack, and #68 preserves local test evidence: targeted stack tests 41 passed; full suite 164 passed; GitHub checks were absent on the split PRs. Review #68 instead. |
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #33 M2 by failing fast when an evaluation dataset has no holdout examples:
_require_non_empty_holdout(...)to reject empty holdout splits before optimization startsclick.ClickExceptioninstead of silently producing 0.000/0.000 holdout scoresRoot cause
The holdout scoring code uses
sum(scores) / max(1, len(scores)). Whendataset.holdoutis empty, both baseline and evolved score lists are empty, so the report silently shows 0.000 scores rather than warning that no independent evaluation occurred.Opposite-perspective review notes
I checked the skeptical cases:
Test Plan
pytest tests/skills/test_evolve_skill_dataset_gates.py -qfailed because_require_non_empty_holdoutdid not existpytest tests/skills/test_evolve_skill_dataset_gates.py -qpytest -qgit diff --checkResult: 141 passed, 11 warnings (DSPy deprecation warnings only).
Partially addresses #33 (M2: empty holdout set silently produces 0.000 scores).