fix: enforce run-tests evolution gate#58
Closed
steezkelly wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this PR in favor of consolidated PR #68. Local integration found real helper-block overlap in evolution/skills/evolve_skill.py across the stack, and #68 preserves local test evidence: targeted stack tests 41 passed; full suite 164 passed; GitHub checks were absent on the split PRs. Review #68 instead. |
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the #33 C2 audit finding that
--run-testswas a no-op:EvolutionConfig.run_pytestinto the evolution pipelineConstraintValidator.run_test_suite(...)after evolved skill constraints pass and before holdout/output promotionoutput/<skill>/evolved_FAILED_TESTS.mdfor inspectionrun_pytest=Falsepythontosys.executableso the gate uses the active interpreter instead of depending on a shellpythonaliasRoot cause
evolve_skill.evolve(...)storedrun_pytest=run_testsinEvolutionConfig, andConstraintValidator.run_test_suite(...)existed, but nothing called it. The CLI advertised a test gate that never executed.Opposite-perspective review notes
I specifically checked the skeptical cases:
_run_pytest_gate_if_requested(...)calls the validator only whenconfig.run_pytestis true.sys.executableever be the wrong interpreter for a separate Hermes repo? Possibly in a future multi-venv setup; this is still more deterministic than barepython, and a configurable pytest command would be a good later enhancement.Test Plan
_run_pytest_gate_if_requesteddid not existpytest tests/skills/test_evolve_skill_gates.py tests/core/test_constraints.py::TestRunTestSuite::test_uses_current_python_interpreter -qpytest -qgit diff --checkResult: 141 passed, 11 warnings (DSPy deprecation warnings only).
Partially addresses #33 (C2: dead
--run-testsconfig).