Skip to content

Conversation

@NickLocke
Copy link
Contributor

No description provided.

Copy link
Member

@dpslwk dpslwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HMS code base uses single quoted strings with concatenation . not interpolation

Audit runs weekdays only not daily.
The message is form the "Hackspace Management System" bot not sure it needs to be pointed out in every message.

I don't like the mixing of the count in to sentences as it makes scanning the notification for just the numbers hard, word prefer them to be on separate lines,
there is also existing wording in the email version in auditResults.blade.php

bare in mind that the public discord membership channel is fairly quite and so there will be weeks when all the channel sees is the same thing posted over and over

@NickLocke NickLocke closed this Dec 4, 2025
@NickLocke
Copy link
Contributor Author

HMS code base uses single quoted strings with concatenation . not interpolation - amended, my bad, in my day job interpolation is seen as clearer.

Audit runs weekdays only not daily - amended to reflect that.

The message is form the "Hackspace Management System" bot not sure it needs to be pointed out in every message - message text adjusted to remove the duplicate mention of HMS.

I don't like the mixing of the count in to sentences as it makes scanning the notification for just the numbers hard, word prefer them to be on separate lines - The intended audience isn't "us", it is all of the membership. In my view English sentences are better for that.

there is also existing wording in the email version in auditResults.blade.php - yes, I see that email every weekday. I have reused that wording, tweaked slightly for the intended audience.

bare in mind that the public discord membership channel is fairly quite and so there will be weeks when all the channel sees is the same thing posted over and over - true, but not sure that is an issue?

@NickLocke NickLocke reopened this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants