Added -Wextra to unit test workflows to catch more warnings/suggestions

.github/workflows/asan_unit_tests.yml

@@ -16,6 +16,6 @@ jobs:
     - name: Run autotools / configure
       run: ./autogen.sh --enable-debug
     - name: Compile and link (make)
-      run: make -j8 CFLAGS="-Werror -Wall -fsanitize=address" LDFLAGS="-fsanitize=address"
+      run: make -j8 CFLAGS="-Werror -Wextra -Wno-sign-compare -Wall -fsanitize=address" LDFLAGS="-fsanitize=address"
     - name: Run unit tests
       run: make -C tests/unit CFLAGS="-fsanitize=address" LDFLAGS="-fsanitize=address" check

.github/workflows/macos_unit_tests.yml

@@ -21,6 +21,6 @@ jobs:
       run: >
         ./autogen.sh --enable-debug
     - name: Compile and link
-      run: MACOSX_DEPLOYMENT_TARGET=15.4 make -j8 CFLAGS="-Werror -Wall"
+      run: MACOSX_DEPLOYMENT_TARGET=15.4 make -j8 CFLAGS="-Werror -Wextra -Wno-sign-compare -Wall"
     - name: Run unit tests
       run: make -C tests/unit check

.github/workflows/unit_tests.yml

@@ -31,6 +31,6 @@ jobs:
     - name: Run autotools / configure
       run: ./autogen.sh --enable-debug
     - name: Compile and link (make)
-      run: make CFLAGS="-Wall -Wextra -Werror -Wno-sign-compare"
+      run: make CFLAGS="-Wall -Wextra -Wno-sign-compare -Werror -Wextra -Wno-sign-compare"
     - name: Run unit tests
       run: make -C tests/unit check

libutils/unix_dir.c

@@ -92,7 +92,7 @@ const struct dirent *DirRead(Dir *dir)
 {
     assert(dir != NULL);
     errno = 0;
-#ifdef __linux__
+#if defined __linux__ || defined DARWIN
     return readdir((DIR *) dir->dirh); // Sets errno for error
 #else // "exotics" use readdir_r