Skip to content

4218-uploads-not-displaying-on-parts-review-page clear stale files state when part form modals close #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RemainingDelta wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

4218-uploads-not-displaying-on-parts-review-page clear stale files state when part form modals close #4224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...e/ProjectViewContainer/PartReview/PartReviewComponents/PartFormModels/ReviewFormModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useToast } from '../../../../../../hooks/toasts.hooks';
import * as yup from 'yup';
import { Controller, useFieldArray, useForm } from 'react-hook-form';
import { yupResolver } from '@hookform/resolvers/yup';
import React, { useState } from 'react';
import React, { useEffect, useState } from 'react';
import NERFormModal from '../../../../../../components/NERFormModal';
import { Autocomplete, Button, Grid, IconButton, List, ListItem, Typography } from '@mui/material';
import { FormControl, FormHelperText, FormLabel, TextField } from '@mui/material';
Expand All @@ -25,6 +25,13 @@ const ReviewFormModal = ({ open, handleClose, defaultValues, onSubmit, partsInPr
const [uploading, setUploading] = useState(false);
const { mutateAsync: uploadFile } = useUploadFile();

useEffect(() => {
Copy link
Copy Markdown
Contributor

@wavehassman wavehassman May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a useEffect in both files, just wrap handleClose in a callback that also clears the state. Then update the onHide= call. It should look something like this:

const handleCloseAndReset = () => {
  setFiles([]);
  setSelectedPartIndex(undefined); 
  handleClose();
};

if (!open) {
setFiles([]);
setSelectedPartIndex(undefined);
}
}, [open]);

const schema = yup.object().shape({
submissionId: yup.string().required(),
notes: yup.string().optional(),
Expand Down
6 changes: 6 additions & 0 deletions ...ojectViewContainer/PartReview/PartReviewComponents/PartFormModels/SubmissionFormModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ const SubmissionFormModal = ({
const [uploading, setUploading] = useState(false);
const { mutateAsync: uploadFile } = useUploadFile();

useEffect(() => {
if (!open) {
setFiles([]);
}
}, [open]);

const schema = yup.object().shape({
partId: yup.string().required(),
name: yup.string().required(),
Expand Down
Loading