Skip to content

#646 - Adopt Matt Pocock agent skills and restructure Claude Code config#647

Draft
bracyw wants to merge 16 commits into
developfrom
646-adopt-matt-pocock-skills
Draft

#646 - Adopt Matt Pocock agent skills and restructure Claude Code config#647
bracyw wants to merge 16 commits into
developfrom
646-adopt-matt-pocock-skills

Conversation

@bracyw
Copy link
Copy Markdown
Collaborator

@bracyw bracyw commented Jun 1, 2026

Changes

Adopts Matt Pocock's agent-skill framework as the AI-driven path for issue authoring and engineering work, and restructures the repo's Claude Code config to match. Lands in three groups: docs (agent config under docs/agents/, ADR 0002, a workflow glossary), skills (the 14 Matt skills plus the 7 Argos workflow skills, now tracked in .claude/skills/), and code rules (per-subdirectory CLAUDE.md for angular-client and scylla-server, a project-focused root CLAUDE.md, and pruned issue templates).

  • Two-path issue authoring: AI files via Matt's body shapes through gh issue create, humans keep the YAML form templates; the ready-for-agent label distinguishes AI-filed issues. Rationale and the rejected single-path alternative are in docs/adr/0002-misc-adopt-matt-pocock-skills.md.
  • commit, open-pr, and update-pr carry small labeled borrows from Matt's caveman and writing-shape skills: terser commit descriptions, plus a format-selection menu and a reader-filter pass for PR bodies.
  • Five triage labels (needs-triage, needs-info, ready-for-agent, ready-for-human, wontfix) created on the repo; spike and other issue templates removed, leaving task, bug-form, feature-request, epic.

Notes

  • This is the first committed CLAUDE.md in the repo. It is project-focused (overview, local dev, testing, conventions, safety, plus pointers to the subdir files) and deliberately omits the local bare-repo worktree workflow, which stays in the untracked worktrees-root CLAUDE.md and still parent-merges for that setup.
  • The two subdir CLAUDE.md files port the former .claude/rules/ frontend and backend guidelines, minus the Cursor-style globs frontmatter that Claude Code ignores.
  • Follow-ups, intentionally out of this PR: redesigning the worktree-root start-ticket skill to branch on the triage label (autonomous vs interactive), and a post-merge cleanup pass on the local worktree-root skill set.

Test Cases

  • Confirmed the three commits group cleanly (docs / skills / code rules) with a clean working tree afterward: 54 files, no stray inclusions.
  • Confirmed the 5 triage labels exist on the repo with the intended colors and descriptions.
  • Confirmed no merge conflicts against develop.
  • Spot-checked the migrated skill files and that the docs cross-references resolve.

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #646

@bracyw bracyw self-assigned this Jun 1, 2026
@bracyw bracyw requested a review from TheJeffreyKuo June 1, 2026 02:40

Open the corresponding JSON in the firmware definitions repo:
```
/Users/wyattbracy/Desktop/ner/firmware/Odyssey-Definitions/can-messages/
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaks local

Comment thread .claude/skills/verify-graph/SKILL.md
cd angular-client && npm install && npm start
```

Navigate to the relevant page with Playwright, wait for data, and take a screenshot:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative pictures/ lands inside the worktree when run from one, which conflicts with the root CLAUDE.md which says screenshots live at worktrees-root, because it risks committing them

**Section A — Issue tracker.**

> Explainer: The "issue tracker" is where issues live for this repo. Skills like `to-issues`, `triage`, `to-prd`, and `qa` read from and write to it — they need to know whether to call `gh issue create` or follow some other workflow you describe. Pick the place you actually track work for this repo.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qa skill doesn't exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt Matt Pocock agent skills and restructure Claude Code config

3 participants