Open
Conversation
made sure to make the postcard an array
Paris2020
reviewed
Aug 15, 2024
| userAvatarContainer.src = !!json.avatar ? json.avatar : "../images/no_avatar.jpg"; | ||
| } catch (error) { | ||
| // THROW ERROR | ||
| throw new Error(error); |
There was a problem hiding this comment.
Catching an error and then throwing it does not make sense.
| alert("Invalid email or password"); | ||
| } | ||
| } catch (error) { | ||
| throw new Error(error, "An error occurred!"); |
There was a problem hiding this comment.
The same comment about catching an error and then throwing it applies here as well.
| // Display error message | ||
| userPostsContainer.innerHTML = errorMessage; | ||
| // Rethrow the error for external handling, if necessary | ||
| throw new Error(error); |
There was a problem hiding this comment.
Just keep this habit in mind in the future please - catching an error and then throwing it.
| singlePostContainer.innerHTML = errorMessage; | ||
|
|
||
| // Rethrow the error for external handling, if necessary | ||
| throw new Error(error); |
| return json; | ||
| } catch (error) { | ||
| // THROW ERROR | ||
| throw new Error("An error occurred during the fetch operation", error); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My JS2 pull request. Assignment Javascript 2 (resit).
oct 2022 full time student.
Using Noroff Api Doc v1