Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR adds a test case to reproduce issue edr#1244, which relates to block number handling after forking with hardhat_reset. The test verifies that when the network is reset with a specific fork block number, the current block number correctly reflects that forked block.
- Adds reproduction test for block number verification after hardhat_reset with forking
- Configures the test to use the Prague hardfork
- Includes conditional skip logic for tests without ALCHEMY_URL configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| hardfork: "prague", | ||
| }); | ||
|
|
||
| it("Issue edr/1244", async function () { |
There was a problem hiding this comment.
The test name 'Issue edr/1244' is not descriptive of what the test validates. Consider renaming to something like 'should return correct block number after hardhat_reset with forking' to clearly describe the expected behavior being tested.
| it("Issue edr/1244", async function () { | |
| it("should return correct block number after hardhat_reset with forking", async function () { |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1257 +/- ##
=======================================
Coverage 73.25% 73.25%
=======================================
Files 436 436
Lines 74168 74183 +15
Branches 74168 74183 +15
=======================================
+ Hits 54330 54342 +12
- Misses 17842 17845 +3
Partials 1996 1996 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a reproduction case for the bug reported in NomicFoundation/hardhat#7834 and fixed by NomicFoundation/hardhat#7850
To Do