Fix/357/use alignment from memory helper#358
Fix/357/use alignment from memory helper#358aaron-iz wants to merge 4 commits intoNoiseStudio:masterfrom
Conversation
|
was there a reason for deleting the temp var? probably doesn't matter tho |
I could add that back, thought it should be deleted by the issue's description. Might be worth to add it back in-case these calls are expensive. |
|
oh you're right, issue sounds like that, but it probably wasn't intended that way. |
|
remember to use curly braces on the previous line (link). also only now i noticed, you should pull master and branch out from here, currently the history might get goofed up (there are commits from previous prs) |
|
IDE does that by default need to disable that. Yep noticed that too, for some reason the sync didn't work as expected |
|
i would probably still prefer doing it on a new branch based on master and not including this mess in the repo (if we squashed everything this wouldn't be an issue...) otherwise lgtm |
a58ba54 to
6dbe43e
Compare
|
branch history fixed |
|
vi changed you should rebase/merge master into this branch and fix compilation errors |
Closes #357.