docs(skill): clarify --all-variants is sequential, not parallel#50
Merged
Merged
Conversation
The nasde-benchmark-runner skill's 'Parallel runs' section showed the &+wait pattern but never warned that --all-variants is the wrong tool for parallelism — it iterates variants in a single process. Agents reading the skill could reasonably pick --all-variants for 'run all variants' and lose concurrency silently. Adds an explicit 'do not use --all-variants when you want parallelism' lead-in plus a one-liner on when --all-variants is actually the right choice (sequential resource budgeting, Claude OOM avoidance). CHANGELOG entry under 0.3.3 since this lands before the v0.3.3 tag is cut.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nasde-benchmark-runnerskill that--all-variantsruns variants sequentially in a single process — agents wanting parallelism must launch separatenasde runprocesses with&andwait.--all-variantsis actually the right choice (sequential resource budgeting, Claude variants where parallel runs risk Docker OOM).[0.3.3]. Last-moment tweak before thev0.3.3tag is cut.Why
The "Parallel runs (multiple variants)" section showed the
&+waitpattern but never said anything about--all-variants. An agent reading "I want to run all variants" could reasonably reach for--all-variantsand silently lose concurrency. The CLI iterates variants in aforloop (cli.py::_run_all_variants), so this isn't a config knob — it's a deliberate sequential mode.Test plan
SKILL.md+CHANGELOG.md); no code/CI surface touched.[0.3.3]section with the same prose style as neighbors.