Skip to content

Fix job levels being reset when adding new jobs via >addjob#357

Closed
kenedos wants to merge 1 commit intoNoCode-NoLife:masterfrom
kenedos:fix_addjob
Closed

Fix job levels being reset when adding new jobs via >addjob#357
kenedos wants to merge 1 commit intoNoCode-NoLife:masterfrom
kenedos:fix_addjob

Conversation

@kenedos
Copy link
Copy Markdown
Contributor

@kenedos kenedos commented Nov 27, 2025

This PR fixes an issue where existing job levels would be incorrectly reduced when adding a new job with the
>addjob command.

Root Cause

The Job.Level property is dynamically calculated from TotalExp and the character's current rank (sum of all job
circles). When a new job is added, the rank increases, which changes the EXP curve - the same TotalExp value now
corresponds to a lower level at the higher rank.

Steps to reproduce (before this fix):

  1. Create new archer character
  2. >joblevelup 14 (Archer is now level 15)
  3. >addjob 3002 (Hunter)
  4. >joblevelup 44 (Hunter is now level 45)
  5. >addjob 3005 (Sapper) - Hunter drops from level 45 to level 9 (not shown in client)
  6. >joblevelup 44 (Sapper is now level 45)
  7. Attempt to increase Hunter's Praise skill → FAIL, because Praise requires job level 31

Fix

Before adding a new job, store the current levels of all existing jobs. After adding the job (which increases the
rank), recalculate TotalExp for each existing job to maintain their levels at the new rank.

@kenedos kenedos changed the title Fix job levels being reset when adding new jobs via /addjob Fix job levels being reset when adding new jobs via >addjob Nov 27, 2025
@exectails
Copy link
Copy Markdown
Member

Thanks for the PR, but I think this might've been fixed in a different way already.

You're right that the level was calculated based on the job's total exp and the character's total rank, but that was actually a bug, and the jobs should never have used the total rank. Instead, they should've used their own rank, ie the rank they were added as. This caused issues with all types of rank and level requirements and was fixed a little while ago.

I just tested your steps to reproduce this issue and it seems like it's working fine now. Perhaps you could try again as well, just to confirm that this is no longer an issue in the latest version of Melia.

@exectails
Copy link
Copy Markdown
Member

I'll close this PR for now, assuming that the issue was indeed fixed.

@exectails exectails closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants