Open
Conversation
Contributor
Author
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized backtest_splits for already sorted data.
When running on large data sets we observed running into memory issues when running backtest functionality (inside mlforecast). This tried to remove some memory overhead and at the same time created speed inreases.
Instead of creating full-length per-row date arrays and boolean masks for every CV window, the new code computes train/validation boundaries per series and slices rows by index ranges. That reduces peak memory and speeds up splitting on large panels. Unsorted inputs still use the old implementation, so existing behavior stays unchanged there.
Performance test showed really good performance compared to old logic.
Old logic took 28 sec and had 5781 MB in peak mem usage, while the suggested logic used finished in 17 sec and only used 3128 MB in peak mem usage on 50 mill rows in the code below: