Skip to content

krr: 1.7.1 -> 1.28.0#502031

Open
JamieMagee wants to merge 2 commits intoNixOS:masterfrom
JamieMagee:krr-fix-327629
Open

krr: 1.7.1 -> 1.28.0#502031
JamieMagee wants to merge 2 commits intoNixOS:masterfrom
JamieMagee:krr-fix-327629

Conversation

@JamieMagee
Copy link
Copy Markdown
Member

Update krr and its dependency prometrix to fix the build. krr has been broken since mid-2024 because prometrix was marked broken against prometheus-api-client >= 0.5.3 (nixpkgs has 0.7.0). Upstream fixed the incompatibility a while ago.

  • prometrix: 0.1.18-unstable-2024-04-30 -> 0.2.11-unstable-2026-03-11 (removes broken flag)
  • krr: 1.7.1 -> 1.28.0

The upstream tests use a deprecated click API (CliRunner(mix_stderr=False)) so they're disabled. pythonImportsCheck passes and krr version returns 1.28.0.

Fixes: #327629

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 21, 2026
@JamieMagee

This comment was marked as outdated.

Copy link
Copy Markdown
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add an updateScript.

Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/development/python-modules/prometrix/default.nix Outdated
Comment thread pkgs/development/python-modules/prometrix/default.nix Outdated
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 22, 2026
@JamieMagee JamieMagee requested a review from dotlambda March 22, 2026 06:00
Comment thread pkgs/by-name/kr/krr/package.nix Outdated
Comment thread pkgs/development/python-modules/prometrix/default.nix Outdated
@JamieMagee JamieMagee force-pushed the krr-fix-327629 branch 3 times, most recently from 6e1c252 to 5c55a34 Compare March 23, 2026 19:50
@JamieMagee JamieMagee requested a review from dotlambda March 23, 2026 19:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 23, 2026
@JamieMagee

This comment was marked as outdated.

Comment thread pkgs/by-name/kr/krr/package.nix Outdated
@nixpkgs-ci nixpkgs-ci bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 29, 2026
@JamieMagee
Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 502031
Commit: 59bd5c403937179107710e9251bf4a26a3c622fa (subsequent changes)
Merge: 290930e5595c20f5509cd981e541e7eacfba8f9d

Logs: https://github.com/JamieMagee/nixpkgs-review-gha/actions/runs/23720889546


x86_64-linux

❌ 2 packages failed to build:
  • python314Packages.prometrix
  • python314Packages.prometrix.dist
✅ 4 packages built:
  • krr
  • krr.dist
  • python313Packages.prometrix
  • python313Packages.prometrix.dist

Error logs: `x86_64-linux`
python314Packages.prometrix
    inferred = ModelField.infer(
        name=var_name,
    ...<3 lines>...
        config=config,
    )
  File "/nix/store/a9pz1c8ychxi07nwl15by4ic77fdnwwv-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 504, in infer
    return cls(
        name=name,
    ...<7 lines>...
        field_info=field_info,
    )
  File "/nix/store/a9pz1c8ychxi07nwl15by4ic77fdnwwv-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 434, in __init__
    self.prepare()
    ~~~~~~~~~~~~^^
  File "/nix/store/a9pz1c8ychxi07nwl15by4ic77fdnwwv-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 544, in prepare
    self._set_default_and_type()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/nix/store/a9pz1c8ychxi07nwl15by4ic77fdnwwv-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 576, in _set_default_and_type
    raise errors_.ConfigError(f'unable to infer type for attribute "{self.name}"')
pydantic.v1.errors.ConfigError: unable to infer type for attribute "prometheus_auth"

aarch64-linux

❌ 2 packages failed to build:
  • python314Packages.prometrix
  • python314Packages.prometrix.dist
✅ 4 packages built:
  • krr
  • krr.dist
  • python313Packages.prometrix
  • python313Packages.prometrix.dist

Error logs: `aarch64-linux`
python314Packages.prometrix
    inferred = ModelField.infer(
        name=var_name,
    ...<3 lines>...
        config=config,
    )
  File "/nix/store/imynf08w2ydxzwc2dr5c1289jxybnyly-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 504, in infer
    return cls(
        name=name,
    ...<7 lines>...
        field_info=field_info,
    )
  File "/nix/store/imynf08w2ydxzwc2dr5c1289jxybnyly-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 434, in __init__
    self.prepare()
    ~~~~~~~~~~~~^^
  File "/nix/store/imynf08w2ydxzwc2dr5c1289jxybnyly-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 544, in prepare
    self._set_default_and_type()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/nix/store/imynf08w2ydxzwc2dr5c1289jxybnyly-python3.14-pydantic-2.12.5/lib/python3.14/site-packages/pydantic/v1/fields.py", line 576, in _set_default_and_type
    raise errors_.ConfigError(f'unable to infer type for attribute "{self.name}"')
pydantic.v1.errors.ConfigError: unable to infer type for attribute "prometheus_auth"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: krr

2 participants