Open
Conversation
fd67a79 to
f578882
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dotlambda
reviewed
Mar 22, 2026
Member
dotlambda
left a comment
There was a problem hiding this comment.
Would be nice to add an updateScript.
f578882 to
af504a9
Compare
dotlambda
reviewed
Mar 23, 2026
dotlambda
reviewed
Mar 23, 2026
6e1c252 to
5c55a34
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dotlambda
reviewed
Mar 23, 2026
5c55a34 to
59bd5c4
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update krr and its dependency prometrix to fix the build. krr has been broken since mid-2024 because prometrix was marked broken against prometheus-api-client >= 0.5.3 (nixpkgs has 0.7.0). Upstream fixed the incompatibility a while ago.
brokenflag)The upstream tests use a deprecated click API (
CliRunner(mix_stderr=False)) so they're disabled.pythonImportsCheckpasses andkrr versionreturns1.28.0.Fixes: #327629
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.