ctranslate2: fix CMake 4 compatibility#450313
Draft
Daviey wants to merge 1 commit intoNixOS:masterfrom
Draft
Conversation
Adds a patch file to update cmake_minimum_required from 3.7 to 3.10 in the main CMakeLists.txt files. Keeps the existing postPatch for vendored dependencies since those are git submodules that can't be easily patched with patch files. CMake 4 doesn't support versions older than 3.5, and versions between 3.5-3.10 are deprecated. Upstream is working on a similar fix in OpenNMT/CTranslate2#1907 Fixes: NixOS#450258 Signed-off-by: Dave Walker <dave@daviey.com>
Member
|
Sorry, I don't understand. The |
Contributor
|
The build works, anything in the interval Seeing as upstream is working on a bump to 3.10 cmake min version, we may get away with ignoring this and just doing a regular version bump later. There is no immediate need to change anything. |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a patch file to update cmake_minimum_required from 3.7 to 3.10 in the main CMakeLists.txt files. Keeps the existing postPatch for vendored dependencies since those are git submodules that can't be easily patched with patch files.
CMake 4 doesn't support versions older than 3.5, and versions between 3.5-3.10 are deprecated.
Upstream is working on a similar fix in OpenNMT/CTranslate2#1907
Fixes: #450258