ocamlPackages.lua-ml: 0.9.2 -> 0.9.4#414245
Merged
Merged
Conversation
github-actions
Bot
added
the
6.topic: ocaml
github-actions
Bot
added
10.rebuild-darwin: 1-10
vbgl
reviewed
Jun 11, 2025
Contributor
There was a problem hiding this comment.
Suggested change
| odoc |
Are you sure this library is needed?
Member
Author
There was a problem hiding this comment.
Thenks for pointing it out. I fixed three.
odocis removed from buildInputs. It is only needed to generate document, but I overlooked it.menhiris removed from buildInputs. It is included in lua-ml, so not need in buildPhase.minimalOCamlVersionis removed because of OCaml < 4.08.
Contributor
There was a problem hiding this comment.
Please do set minimalOCamlVersion to "4.07".
Contributor
|
Re-running CI due to a odd failure fixed in #416448 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: lindig/lua-ml@0.9.2...0.9.4
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.