Skip to content

flann: don't unbundle lz4 for clang#173890

Merged
siraben merged 1 commit intoNixOS:masterfrom
risicle:ris-flann-clang-fix
May 21, 2022
Merged

flann: don't unbundle lz4 for clang#173890
siraben merged 1 commit intoNixOS:masterfrom
risicle:ris-flann-clang-fix

Conversation

@risicle
Copy link
Copy Markdown
Contributor

@risicle risicle commented May 21, 2022

Description of changes

unbundling appears broken with the llvm toolchain:

flann-lib/flann#399 (comment)

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

unbundling appears broken with the llvm toolchain:

flann-lib/flann#399 (comment)
@risicle risicle added the 0.kind: build failure A package fails to build label May 21, 2022
@ofborg ofborg Bot requested a review from viric May 21, 2022 14:49
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 21, 2022
@risicle risicle marked this pull request as ready for review May 21, 2022 15:09
@siraben
Copy link
Copy Markdown
Member

siraben commented May 21, 2022

Result of nixpkgs-review pr 173890 run on aarch64-darwin 1

1 package built:
  • flann

@siraben
Copy link
Copy Markdown
Member

siraben commented May 21, 2022

Result of nixpkgs-review pr 173890 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • pcl
1 package built:
  • flann

@siraben siraben merged commit bf6b514 into NixOS:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: build failure A package fails to build 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants