Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My impressions of @marcin-serwin has been nothing short of stellar. They've been a great contributor, maintainer, and reviewer since the moment they joined. They're patient with people and able to catch non-trivial problems. They're also a cmake wizard who on several occasions have dived in to diagnose and patch some rather involved upstream issues. Marcin says they do not have much experience with modules, but this is IMO evidence of a healthy caution and knowing when to be confident and when to defer decision-making to others.
I believe marcin-serwin will be a great committer.
stats
@r-ryantm@r-ryantm@r-ryantm