Skip to content

[18.0][MIG] mass_mailing_double_opt_in_nitrokey: Migration to v18.0#251

Merged
jans23 merged 4 commits into18.0from
18.0-mig-mass_mailing_double_opt_in_nitrokey
Apr 9, 2026
Merged

[18.0][MIG] mass_mailing_double_opt_in_nitrokey: Migration to v18.0#251
jans23 merged 4 commits into18.0from
18.0-mig-mass_mailing_double_opt_in_nitrokey

Conversation

@hitesh-erpharbor
Copy link
Copy Markdown
Contributor

No description provided.

@jans23
Copy link
Copy Markdown
Member

jans23 commented Apr 7, 2026

Please rebase.

@hitesh-erpharbor hitesh-erpharbor force-pushed the 18.0-mig-mass_mailing_double_opt_in_nitrokey branch from 6c943e2 to 3e450b0 Compare April 9, 2026 06:58
@jans23
Copy link
Copy Markdown
Member

jans23 commented Apr 9, 2026

Why does this PR add two modules: mass_mailing_double_opt_in_nitrokey and website_mass_mailing_double_opt_in_nitrokey ?

@hitesh-erpharbor
Copy link
Copy Markdown
Contributor Author

mass_mailing_double_opt_in_nitrokey is the old module name. We have simply renamed it to website_mass_mailing_double_opt_in_nitrokey.

@jans23
Copy link
Copy Markdown
Member

jans23 commented Apr 9, 2026

So why do you add the old module? We don't need it anymore.

@jans23 jans23 merged commit adf7a79 into 18.0 Apr 9, 2026
1 check passed
@jans23 jans23 deleted the 18.0-mig-mass_mailing_double_opt_in_nitrokey branch April 9, 2026 08:11
jans23 pushed a commit that referenced this pull request Apr 12, 2026
…251)

* [18.0][MIG] mass_mailing_double_opt_in_nitrokey: Migration to v18.0

* [18.0][IMP] mass_mailing_double_opt_in_nitrokey: Renamed module name to website_mass_mailing_double_opt_in_nitrokey

* [18.0][IMP] website_mass_mailing_double_opt_in_nitrokey: Implemented email translated values

* [REM] Removed old module  mass_mailing_double_opt_in_nitrokey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants