make frame a public property on NKLineChart.#2
Open
cconeil wants to merge 1 commit intoNilStack:masterfrom
Open
make frame a public property on NKLineChart.#2cconeil wants to merge 1 commit intoNilStack:masterfrom
cconeil wants to merge 1 commit intoNilStack:masterfrom
Conversation
Owner
|
Sorry for the late response. Thanks for your pulling request, @cconeil . I will check if other chart types also need this and then merge it. |
Author
|
Great, thanks! No rush on this. I'm using my fork for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking through and realized that the frame could be set after it was initialized. This was the only problem that I was having with this library, and it turns out that it was a simple fix :)
Hope this helps!