Update add somme function and GUI tools

[JM2K69]

Requirements

• This template is required. Any request that does not include enough information may be closed at the maintainers' discretion.
• Have you (put an X between the brackets on each line to confirm):
  • Written new test cases to ensure no regression bugs occur?
  • Ensured all test cases are now passing?
  • Ensured that PowerShell Script Analyser issues and warnings are completely resolved?
  • Updated any help or documentation that may be impacted by your changes?

Description of the Change

[ We must be able to understand the design of your change from this description. If we cannot get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts. ]

Testing

[ Please describe the testing you have performed ]

Associated/Resolved Issues

[ Enter any applicable issues here ]

Note: By creating a pull request, you are expected to comply with this project's Code of Conduct.

[Copilot]

Pull request overview

This pull request adds a new GUI-based GPO Policy Manager and updates existing functions in the PSGPOTools module. While it introduces significant new functionality, there are several critical bugs and maintainability issues that should be addressed before merging.

Key Changes:

• Added a Scope parameter to Get-PSGPOPolicy function to filter policies by User or Machine scope
• Enhanced Initialize-PSGPOAdmx with improved formatting and comments
• Introduced a new Show-GPOManager function providing a WPF-based graphical interface for browsing and managing GPO policies

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

In the Populate-TreeView function, the filter condition checks three different conditions for the same value which is redundant. The condition "$Filter -and $Filter -ne '' -and $Filter -ne 'Rechercher une GPO...'" can be simplified since the placeholder check already handles the empty string case. Consider simplifying to just check if the filter is meaningful.

Suggested change

	if ($Filter -and $Filter -ne '' -and $Filter -ne 'Rechercher une GPO...') {
	if (-not [string]::IsNullOrWhiteSpace($Filter) -and $Filter -ne 'Rechercher une GPO...') {

[Copilot]

The nested Set-Theme function is defined inside Show-GPOManager but lacks any documentation. The function takes a boolean parameter but doesn't document what it does or what the parameter means. Adding inline documentation would improve code maintainability.

[Copilot]

The function Populate-TreeView and the theme toggle functionality access and modify variables from the outer scope without proper scoping. The click handlers and nested functions rely on closure over variables like $treeView, $window, etc. While PowerShell supports this, explicitly documenting or structuring this dependency would improve maintainability. Consider using a more structured approach with a class or explicitly passing required references.

[Copilot]

The new Show-GPOManager function lacks any documentation. There is no comment-based help, no description of what the function does, its purpose, or usage examples. This is especially important for a complex GUI function that introduces significant new functionality. Consider adding proper PowerShell comment-based help with .SYNOPSIS, .DESCRIPTION, .EXAMPLE, etc.

Suggested change

	<#
	.SYNOPSIS
	Displays the PSGPOTools GPO Manager graphical user interface.
	.DESCRIPTION
	Show-GPOManager opens a WPF-based graphical user interface that allows you to
	browse, search, and inspect Group Policy settings and related information
	loaded by Initialize-PSGPOAdmx. The GUI uses the ADMX/ADML data parsed and
	cached by GPOToolsUtility and provides an interactive way to explore policies,
	categories, and supported platforms.
	This command requires a Windows environment with GUI capabilities because it
	relies on WPF assemblies (PresentationFramework, PresentationCore, WindowsBase).
	For accurate data, run Initialize-PSGPOAdmx prior to launching the manager so
	that ADMX/ADML definitions are loaded.
	.EXAMPLE
	PS C:\> Show-GPOManager
	Launches the GPO Manager UI using the ADMX/ADML data previously initialized
	with Initialize-PSGPOAdmx.
	.EXAMPLE
	PS C:\> Initialize-PSGPOAdmx -Path "C:\Windows\PolicyDefinitions"
	PS C:\> Show-GPOManager
	Initializes the ADMX/ADML definitions from the specified PolicyDefinitions
	directory and then opens the GPO Manager GUI to browse those settings.
	.NOTES
	The window is created using Windows Presentation Foundation (WPF). Ensure that
	you are running in a PowerShell session that supports WPF (e.g. PowerShell
	running on Windows with access to a desktop session).
	#>

[Copilot]

The Populate-TreeView function lacks documentation explaining its purpose, the Filter parameter, and its behavior. This is a complex function with significant logic that would benefit from clear documentation.

[Copilot]

The comment contains French text mixed with English. Text strings in lines 927, 938, 941, and throughout the GUI use French ("Mode Sombre", "Mode Clair", "Rechercher une GPO...", etc.), including error messages and placeholders (lines 1251, 1256-1258, 1265, 1273, 1278-1283). For consistency and maintainability, the codebase should use a single language consistently, or implement proper localization/internationalization support.

[Copilot]

The nested loops iterate through parent categories and tree items to build hierarchical structure. This could result in poor performance with a large number of policies or deep category hierarchies (O(n*m) complexity). Consider using a dictionary/hashtable to cache category items by their DisplayName for faster lookups instead of iterating through all items each time.

[Copilot]

The menu item click handlers only output to Write-Host without implementing any actual functionality. These handlers appear to be placeholder implementations that don't perform the actions their names suggest (enabling/disabling parameters, creating GPOs). This could confuse users who expect these menu items to work.

[Copilot]

The hardcoded icon path "pack://application:,,,/icon.ico" will likely fail in most installations since no icon.ico file is included in the module. The try-catch silently ignores the error, which is good for graceful degradation, but this hardcoded path should either be removed, made configurable, or point to an actual bundled resource.

Suggested change

	try {
	$window.Icon = [System.Windows.Media.Imaging.BitmapImage]::new([Uri]::new("pack://application:,,,/icon.ico"))
	} catch {
	# Icon not found, continue without it
	$iconPath = Join-Path -Path $PSScriptRoot -ChildPath 'icon.ico'
	if (Test-Path -LiteralPath $iconPath) {
	try {
	$iconUri = [System.Uri]::new((Resolve-Path -LiteralPath $iconPath))
	$window.Icon = [System.Windows.Media.Imaging.BitmapImage]::new($iconUri)
	} catch {
	# Icon failed to load, continue without it
	}

[Copilot]

The function uses a script-scoped variable $script:isDarkTheme but initializes a local variable $isDarkTheme on line 1096. This inconsistency could cause issues - the Add_Click handler references $script:isDarkTheme while the initial assignment is to a local variable. The initial assignment should be $script:isDarkTheme = $false to match the reference in the click handler.

Suggested change

	$isDarkTheme = $false
	$script:isDarkTheme = $false