Fix Mac build failure with zlib static library detection#13
Draft
Fix Mac build failure with zlib static library detection#13
Conversation
Author
|
@NiceneNerd 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: NiceneNerd <6720029+NiceneNerd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Build on Mac fails finding static zlib
Fix Mac build failure with zlib static library detection
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Mac build failure where
cargo buildwould fail with:The issue was caused by multiple problems in the zlib-ng build process:
libz.a,libzlib.a, orlibz-ng.a), but the build script always tried to link withzlibChanges Made
Enhanced error handling: Added proper error checking for both CMake configure and build steps with descriptive panic messages to help diagnose issues.
Dynamic library detection: The build script now automatically detects which zlib library was actually built and links appropriately:
Target-specific builds: Only build the
zlibtarget to avoid test compilation failures that can prevent library creation.Improved Mac support: Explicitly force static builds and ensure proper architecture flags are set for both Intel and Apple Silicon Macs.
The fix makes the build process robust across different platforms and zlib-ng configurations, ensuring that the "could not find native static library" error is resolved by adapting to whatever library is actually produced.
Fixes #12.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.