Feat/recursive search #13
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all Condition expressions to use '$(Property)' string comparisons for true/false and empty checks, instead of relying on unquoted property expansions.
Added `AppDataDeployDir` to specify the deployment directory for Revit add-ins. Updated the copying and cleaning processes to use the new path instead of the previous hardcoded location, ensuring proper management of add-in files during the build process.
Introduce the AppendVersion property (with an optional VersionDelimiter) to deploy the add-in into a versioned folder instead of using the bare assembly name. When this is enabled, the manifest’s Assembly path and the clean step are updated to target the versioned folder.
Update Readme.md to include a new section on enabling versioned folder deployment for Revit add-ins. Document the default local deployment behavior, how to use the AppendVersion property as well as the optional VersionDelimiter, and provide an example XML configuration.
Added an optional DeployToProgramData flag to allow deploying the Revit add-in under %ProgramData% instead of %AppData%, centralized the DeployDir logic so all deploy/update/clean targets use the same base path, and introduced the AddinManifestFileName ($(AssemblyName).addin) property to reference the manifest consistently across all targets and the PowerShell update step.
…e).addin can be located in any subfolder while still using a single fixed manifest name across publish/deploy targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Allow the .addin manifest to be discovered in any subfolder of the project via recursive lookup.
Description:
This change updates the MSBuild targets to resolve the Revit add-in manifest using a recursive search under the project directory. This enables the .addin file to live in the project root or any subfolder while still being picked up correctly for publish and local deployment. The existing workflow is preserved, and the manifest name is centralized via the AddinManifestFileName property for consistent use across publish, deploy, update, and clean targets. Although multiple files with the same name are ignored (only the last one will effectively be used), this aligns with the expected “single manifest per add-in” convention.
Quality Checklist