-
Notifications
You must be signed in to change notification settings - Fork 5
Feat/append version #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update all Condition expressions to use '$(Property)' string comparisons for true/false and empty checks, instead of relying on unquoted property expansions.
Added `AppDataDeployDir` to specify the deployment directory for Revit add-ins. Updated the copying and cleaning processes to use the new path instead of the previous hardcoded location, ensuring proper management of add-in files during the build process.
Introduce the AppendVersion property (with an optional VersionDelimiter) to deploy the add-in into a versioned folder instead of using the bare assembly name. When this is enabled, the manifest’s Assembly path and the clean step are updated to target the versioned folder.
Update Readme.md to include a new section on enabling versioned folder deployment for Revit add-ins. Document the default local deployment behavior, how to use the AppendVersion property as well as the optional VersionDelimiter, and provide an example XML configuration.
…er + fixed AddinManifestFileName for consistent .addin file targeting across all tasks)
|
This project will be migrated to Msbuild SDK, and this repo will be removed. I'm going to change the structure a bit and update User modifiable properties. Btw i dont like implementation with powershell. powershell is a Windows specific tool, i always prefer crossplatform solutions |
|
you can describe what you need, i'll try to add support for something. as i can see some PRs are overcoding and can be solved without the extra code |
|
Hello @Nice3point👋 It would be great if Revit.Build.Tasks had an option to append the version to the add-in folder name (and update the path in the manifest accordingly), similar to what I did in this PR. Some less critical, but still useful, features would be:
Thank you very much once again! |
In the current version:
this is not available in the current version, but will be available in the new SDK https://github.com/Nice3point/RevitTemplates/blob/develop/source/Nice3point.Revit.Sdk/Sdk/Nice3point.Revit.Publish.targets#L16 Release end of the December i guess. .csproj file significantly cleaner now |
Summary of the Pull Request
What is this about:
Add support for deploying the Revit add-in into a versioned folder by appending the assembly version to the deployment directory name.
Description:
This change introduces the AppendVersion and VersionDelimiter properties to the MSBuild targets. When enabled (and when AssemblyVersion is available), local deployment publishes the add-in into a versioned subfolder (e.g. MyAddin_1.2.3) and automatically updates the .addin manifest so the Assembly path points to the versioned folder. When AppendVersion is disabled or no version is available, the existing non-versioned behavior is preserved.
Additionally, some MSBuild property conditional 'boolean' comparisons were updated to consistently use quoted string comparisons ('e.g.' =='true') where they were previously missing, for safety.
Quality Checklist