Initial work on making player data read/update asynchronous#62
Draft
MATRIX-feather wants to merge 6 commits into1.21.11/featurefrom
Draft
Initial work on making player data read/update asynchronous#62MATRIX-feather wants to merge 6 commits into1.21.11/featurefrom
MATRIX-feather wants to merge 6 commits into1.21.11/featurefrom
Conversation
MATRIX-feather
changed the title
MATRIX-feather
commented
Dec 15, 2025
Comment on lines
+303
to
+314
| var dataStore = morphManager.getDataStore(); | ||
| requestedUUIDs.forEach(uuid -> | ||
| { | ||
| dataStore.getOrLoad(uuid).thenAccept(meta -> | ||
| { | ||
| var cmd = new MIS2CSyncMetaCommand(); | ||
| cmd.appendMeta(new SocketPlayerMeta(Operation.ADD_IF_ABSENT, meta.getUnlockedDisguiseIdentifiers(), uuid)); | ||
|
|
||
| logMasterInfo("Synced %s metadata(s) to socket '%s'".formatted(disguises.size(), socket.getRemoteSocketAddress())); | ||
| this.sendCommand(socket, cmd); | ||
| logMasterInfo("Synced metadata for %s to socket '%s'".formatted(uuid, socket.getRemoteSocketAddress())); | ||
| }); | ||
| }); |
Member
Author
There was a problem hiding this comment.
Maybe we should add some kind of batching here, so that we don't send them one by one
Comment on lines
55
to
64
| bindingSlave.requestData(uuid).thenAccept(u -> | ||
| { | ||
| var data = nullablePlayerMeta(u); | ||
|
|
||
| return playerMeta.getUnlockedDisguises(); | ||
| if (data != null) | ||
| future.complete(data); | ||
| else | ||
| future.completeExceptionally(new NullDependencyException("The future of the requested data has been finished, but we can't find a matching data in NetworkDataHolder!")); | ||
| }); | ||
|
|
Member
Author
There was a problem hiding this comment.
This is kind of tricky, and I'm not sure if it's fine. Maybe requesting data should now be NetworkDataHolder's job?
src/main/java/xyz/nifeather/morph/network/multiInstance/slave/NetworkDataHolder.java
Outdated
Show resolved
Hide resolved
…aybe standardize NetworkDataHolder#getOrLoad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some initial work on making player data read/update asynchronous.
The instance network is not tested, and I don't know what will happen, as it's already 5 a.m. right now.