fix(scanner): reject invalid scan paths#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validate the scan target before file discovery and return a scanner error when the path is missing, inaccessible, or not a directory. Add CLI regression coverage for missing paths and file paths.
Why
Invalid scan paths were treated as empty repositories, producing a clean result with exit code 0. This violated the documented exit-code contract and could hide invocation mistakes in local scripts or CI.
Testing
npm run prepublishOnly- passed; build succeeded and 62 tests passed.npm run lint- passed.node bin/opk scan src/cli --json- passed with 0 findings.npm run scan- exited 1 with the existing 18 errors and 33 warnings from repository fixtures and rule definitions.npm pack --dry-run --json- passed with 43 package files.Risks
Callers that previously passed a file path and received a clean result will now receive exit code 2. This matches the documented directory-only CLI contract.
Follow-up
Add scanner coverage for invalid exclusion regular expressions in
opk.config.json.