chore: modified function #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated demo API key functionality and adds error handling to prevent key errors in the get_rules_json() method. The changes also update tests to handle the deprecated demo key status.
- Commented out demo key initialization and related code since demo access is no longer available
- Added error handling to check for 'rules' key existence before processing
- Updated tests to explicitly use the deprecated demo key and handle error scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| valhallaAPI/valhalla.py | Commented out demo key usage and added 'rules' key check in get_rules_json() |
| tests/test_basic.py | Updated to use explicit deprecated demo key and added test for invalid key scenario |
| README.md | Added notice about deprecated demo API key availability |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
secDre4mer
requested changes
Sep 26, 2025
|
|
||
| ## Demo Access | ||
|
|
||
| > Important: The demo API key is not available and demo access is not possible anymore. Hence, the following section and everything regarding the given demo API key is outdated. |
Contributor
There was a problem hiding this comment.
Isn't this too broad?
The demo key is still very much supported and working; only the access to the rule info endpoint has been disabled for the demo key.
Same for changes below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified function get_rules_json() to prevent it from key errors and added test
Edit: additionally updated readme, script and tests due to deprecated demo key