Skip to content

Conversation

@Sauterelle57
Copy link
Member

@Sauterelle57 Sauterelle57 commented Oct 26, 2025

📝 Description

Address all issues identified by SonarCloud's static analysis to improve code quality and maintainability.
Apply coding style rules to all source files in the game engine code.

🔧 Main Changes

  • Fix all security hotspot of sonar
  • Complete most of the documentation in .hpp files
  • Fix main issues on sonar

🧪 Testing

Manual testing of core features and overall usability.
CI/CD is passing (except for unit tests (28.7% != 30% required) => will be done on another branch).

@Sauterelle57 Sauterelle57 self-assigned this Oct 26, 2025
@Sauterelle57 Sauterelle57 added documentation Improvements or additions to documentation code-quality This issue concerns the good practice for code quality sonarcloud This issue concerns the sonarcloud's feedbacks labels Oct 26, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sonar-errors

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…tion + clang tidy errors and warnings in engine/include, engine/src/asset/Asset/Texture, engine/src/asset/Asset/Model and engine/src/asset/Asset/Material
…tion + clang tidy errors and warnings in engine/src/asset/Asset
…tion + clang tidy errors and warnings in engine/src/components
…tion + clang tidy errors and warnings in engine/src/components
…tion + clang tidy errors and warnings in engine/src/ecs
…tion + clang tidy errors and warnings in engine/src/renderer/opengl
…tion + clang tidy errors and warnings in engine/src/renderer/primitives + fix Cylinder.cpp bottom cap vertices order on the bottom cap
…tion + clang tidy errors and warnings in engine/src/renderer
…tion + clang tidy errors and warnings in engine/src/rendererPasses
…tion + clang tidy errors and warnings in engine/src/systems/lights
…tion + clang tidy errors and warnings in engine/src/systems
…tion + clang tidy errors and warnings in engine/example, engine/src
@Sauterelle57 Sauterelle57 changed the title Global clean and code issues fixes Global clean and code issues fix Oct 26, 2025
Copy link
Member

@iMeaNz iMeaNz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not finish, but already posting this so you can check it out, re-request a review once done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality This issue concerns the good practice for code quality documentation Improvements or additions to documentation sonarcloud This issue concerns the sonarcloud's feedbacks

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

ref: apply the coding style on all the code source file fix: resolve all SonarCloud code quality issues

5 participants