-
Notifications
You must be signed in to change notification settings - Fork 1
Global clean and code issues fix #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tion + clang tidy errors and warnings in engine/include, engine/src/asset/Asset/Texture, engine/src/asset/Asset/Model and engine/src/asset/Asset/Material
…tion + clang tidy errors and warnings in engine/src/asset/Asset
…tion + clang tidy errors and warnings in engine/src/components
…tion + clang tidy errors and warnings in engine/src/components
…tion + clang tidy errors and warnings in engine/src/ecs
…tion + clang tidy errors and warnings in engine/src/renderer/opengl
…tion + clang tidy errors and warnings in engine/src/renderer/primitives + fix Cylinder.cpp bottom cap vertices order on the bottom cap
…tion + clang tidy errors and warnings in engine/src/renderer
…tion + clang tidy errors and warnings in engine/src/rendererPasses
…tion + clang tidy errors and warnings in engine/src/systems/lights
…tion + clang tidy errors and warnings in engine/src/systems
…tion + clang tidy errors and warnings in engine/example, engine/src
a0c8ee5 to
cf4c5e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not finish, but already posting this so you can check it out, re-request a review once done
📝 Description
Address all issues identified by SonarCloud's static analysis to improve code quality and maintainability.
Apply coding style rules to all source files in the game engine code.
🔧 Main Changes
🧪 Testing
Manual testing of core features and overall usability.
CI/CD is passing (except for unit tests (28.7% != 30% required) => will be done on another branch).