New theme location for SenchaCmd 3.0.2 & multi-app shared theme proof of concept#26
Open
ilanc wants to merge 3 commits intoNewbridgeGreen:masterfrom
ilanc:master
Open
New theme location for SenchaCmd 3.0.2 & multi-app shared theme proof of concept#26ilanc wants to merge 3 commits intoNewbridgeGreen:masterfrom ilanc:master
ilanc wants to merge 3 commits intoNewbridgeGreen:masterfrom
ilanc:master
Conversation
added 2 commits
January 30, 2013 17:17
* theme resources have moved to shared\packages\bootstrap - can't be arsed to figure out git move * removing build/ directory from github
…ootstrap theme proof of concept
Member
|
Thanks for this Ilan. We've not looked at 3.0.2 yet. I'll try and get a look at this before the end of the week and get it merged! |
Author
|
No problem. If you're looking for a useful task which will teach you about the change:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
I couldn't figure out how to move directories, so have just deleted and recreate in the new location (sorry). I've also re-added the .sencha directories (there are settings files in there which need to be edited in order to get the multi-app / shared theme POC to work).
To use the forked repo:
Note index.html has a demo menu for switching between app1/2/3
Each app uses a shared theme (bootstrap in this case)
You can also load the apps from their source locations e.g.$/app1/index.html - but NB this uses the intermediate build outputs i.e. $ \shared\resources\bootstrap\app.css = so you must build the theme in the shared app before this will work (this is built as part of BuildAll.bat by the commands:
cd shared
sencha app build
The new senchacmd Package structure isolates all Theme files away from the Resources/ directory. This is easier from the build process, but does mean that the Resources/ directory is bare until the app is built i.e.$\app1\index.html won't load until you've built the shared app. During build theme resources are built to $ \shared\resources\bootstrap (intermediate) and then copied to $\build\shared\resources\bootstrap (final). I've excluded the whole of the final build outputs ($ \build) as well as the images from the intermediate dir to save space in the git repo.
Finally - app1,2,3 are pretty unexciting apps - just proof of concept. I've left $\examples untouched, but ideally these should replace app1 & app2.
Let me know what you think.
Ilan