Fix namespace bug for hdmf-experimental types#779
Merged
bendichter merged 4 commits intomainfrom Jan 13, 2026
Merged
Conversation
Adds a workaround for a bug where neurodata types are incorrectly assigned the 'hdmf-experimental' namespace instead of 'hdmf-common'. If the class does not exist for 'hdmf-experimental' but does for 'hdmf-common', the namespace and typename are corrected accordingly. See hdmf-dev/hdmf#1347 for details.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
+ Coverage 95.50% 95.53% +0.02%
==========================================
Files 191 191
Lines 6922 6938 +16
==========================================
+ Hits 6611 6628 +17
+ Misses 311 310 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
why are all the tests failing? |
bendichter
approved these changes
Jan 13, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workaround for a bug where neurodata types are incorrectly assigned the 'hdmf-experimental' namespace instead of 'hdmf-common'. If a MATLAB class does not exist for 'hdmf-experimental' but does for 'hdmf-common', the namespace and typename are corrected accordingly on read
See hdmf-dev/hdmf#1347 for details.
Motivation
Support read for files affected by the issue described above
How to test the behavior?
N/A
Checklist
fix #XXwhereXXis the issue number?