Skip to content

fix: delete vm on sync faliure#443

Merged
aditya-neuraco merged 1 commit intodevelopfrom
fix/delete-vm-on-sync-faliure
Mar 3, 2026
Merged

fix: delete vm on sync faliure#443
aditya-neuraco merged 1 commit intodevelopfrom
fix/delete-vm-on-sync-faliure

Conversation

@aditya-neuraco
Copy link
Copy Markdown
Contributor

Bugfixes

  • VMs get deleted now after synchronisation fails.

Items

Related PRs

@aditya-neuraco aditya-neuraco self-assigned this Feb 24, 2026
@aditya-neuraco aditya-neuraco added the version:patch non-breaking bug fixes; no input/output changes (except defaults) label Feb 24, 2026
@aditya-neuraco aditya-neuraco changed the base branch from main to develop February 24, 2026 19:39
@aditya-neuraco aditya-neuraco force-pushed the fix/delete-vm-on-sync-faliure branch from 537bb66 to 83c2ae8 Compare February 24, 2026 19:47
@aditya-neuraco
Copy link
Copy Markdown
Contributor Author

neuracore_types PR needs to go in before this.

NeuracoreAI/neuracore_types#59

Copy link
Copy Markdown
Member

@CougarTasker CougarTasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM \w comment

Comment thread neuracore/core/data/dataset.py
@stepjam stepjam force-pushed the develop branch 2 times, most recently from e3291a6 to 46fa27a Compare February 28, 2026 07:46
@aditya-neuraco aditya-neuraco force-pushed the fix/delete-vm-on-sync-faliure branch from 83c2ae8 to b897152 Compare March 2, 2026 15:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026

PR source branch is valid

  • Source: fix/delete-vm-on-sync-faliure
  • Target: develop

@aditya-neuraco aditya-neuraco force-pushed the fix/delete-vm-on-sync-faliure branch 2 times, most recently from 0eb6172 to 0e877a7 Compare March 3, 2026 13:14
@aditya-neuraco aditya-neuraco requested review from CougarTasker and removed request for stepjam March 3, 2026 13:56
@aditya-neuraco aditya-neuraco force-pushed the fix/delete-vm-on-sync-faliure branch from 0e877a7 to 60f582c Compare March 3, 2026 17:54
@aditya-neuraco aditya-neuraco merged commit 98b5e7c into develop Mar 3, 2026
8 checks passed
@aditya-neuraco aditya-neuraco deleted the fix/delete-vm-on-sync-faliure branch March 3, 2026 18:23
@nc-version-bumper nc-version-bumper Bot mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch non-breaking bug fixes; no input/output changes (except defaults)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants