Skip to content

fix: fix event loop deadlock on add event source#430

Merged
mark-neuracore merged 4 commits intodevelopfrom
fix/fix-event-loop-deadlock-on-add-event-source
Mar 2, 2026
Merged

fix: fix event loop deadlock on add event source#430
mark-neuracore merged 4 commits intodevelopfrom
fix/fix-event-loop-deadlock-on-add-event-source

Conversation

@mark-neuracore
Copy link
Copy Markdown
Contributor

  • when calling from a thread with the same event loop, the blocking causing a deadlock and it timesout.
  • this should fix it and there is a test to check for this specific case added

@mark-neuracore mark-neuracore self-assigned this Feb 19, 2026
@mark-neuracore mark-neuracore added the version:patch non-breaking bug fixes; no input/output changes (except defaults) label Feb 19, 2026
@mark-neuracore mark-neuracore force-pushed the fix/fix-event-loop-deadlock-on-add-event-source branch from 6fd99ca to a0f8acc Compare February 20, 2026 11:54
@CougarTasker CougarTasker force-pushed the fix/fix-event-loop-deadlock-on-add-event-source branch from a0f8acc to ee93124 Compare February 24, 2026 12:03
@NeuracoreAI NeuracoreAI deleted a comment from github-actions Bot Feb 24, 2026
Comment thread neuracore/core/streaming/p2p/provider/provider_connection.py Outdated
@CougarTasker CougarTasker force-pushed the fix/fix-event-loop-deadlock-on-add-event-source branch from ee93124 to 4f51d2b Compare February 26, 2026 11:08
@mark-neuracore mark-neuracore force-pushed the fix/fix-event-loop-deadlock-on-add-event-source branch 4 times, most recently from 69826b6 to ec1c51d Compare February 27, 2026 10:58
@stepjam stepjam force-pushed the develop branch 2 times, most recently from e3291a6 to 46fa27a Compare February 28, 2026 07:46
@mark-neuracore mark-neuracore force-pushed the fix/fix-event-loop-deadlock-on-add-event-source branch from ec1c51d to 67169b3 Compare February 28, 2026 12:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 28, 2026

PR source branch is valid

  • Source: fix/fix-event-loop-deadlock-on-add-event-source
  • Target: develop

@mark-neuracore
Copy link
Copy Markdown
Contributor Author

@stepjam @muneebneura I have cleaned the battlefield that happened here somehow and retrieved the dangling commit from @CougarTasker and myself. This could have prevented all this mess had I asked Cougar to review the PR and merged it.

This now reverts back the changes @muneebneura added since we moved on to using asyncio tasks.

@CougarTasker @mark-neuracore @muneebneura @stepjam we will need a meeting on monday to discuss the p2p flakiness we have been experiencing recently. Heads up, my experience with asyncio and the async programming lingo is this of a 3-year-old so go easy on me :)

@mark-neuracore
Copy link
Copy Markdown
Contributor Author

mark-neuracore commented Feb 28, 2026

Edit: shout out to @damonhayhurst-neuraco for catching the hilarious typo of peer as "pier" that has been in our repo for about 7 months now :0 !

@mark-neuracore mark-neuracore force-pushed the fix/fix-event-loop-deadlock-on-add-event-source branch from 6a5dada to f736ffc Compare March 2, 2026 11:02
Copy link
Copy Markdown
Member

@CougarTasker CougarTasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am biased @muneebneura/ @damonhayhurst-neuraco give this a scan too

Comment thread neuracore/core/streaming/p2p/provider/provider_connection.py Outdated
Comment thread neuracore/core/streaming/p2p/provider/provider_connection.py Outdated
Copy link
Copy Markdown
Contributor

@damonhayhurst-neuraco damonhayhurst-neuraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ comment

@mark-neuracore mark-neuracore merged commit dd8c71a into develop Mar 2, 2026
8 checks passed
@mark-neuracore mark-neuracore deleted the fix/fix-event-loop-deadlock-on-add-event-source branch March 2, 2026 18:26
@nc-version-bumper nc-version-bumper Bot mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch non-breaking bug fixes; no input/output changes (except defaults)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants