fix: fix event loop deadlock on add event source#430
Conversation
mark-neuracore
commented
Feb 19, 2026
- when calling from a thread with the same event loop, the blocking causing a deadlock and it timesout.
- this should fix it and there is a test to check for this specific case added
6fd99ca to
a0f8acc
Compare
a0f8acc to
ee93124
Compare
ee93124 to
4f51d2b
Compare
69826b6 to
ec1c51d
Compare
e3291a6 to
46fa27a
Compare
ec1c51d to
67169b3
Compare
|
✅ PR source branch is valid
|
|
@stepjam @muneebneura I have cleaned the battlefield that happened here somehow and retrieved the dangling commit from @CougarTasker and myself. This could have prevented all this mess had I asked Cougar to review the PR and merged it. This now reverts back the changes @muneebneura added since we moved on to using asyncio tasks. @CougarTasker @mark-neuracore @muneebneura @stepjam we will need a meeting on monday to discuss the p2p flakiness we have been experiencing recently. Heads up, my experience with asyncio and the async programming lingo is this of a 3-year-old so go easy on me :) |
|
Edit: shout out to @damonhayhurst-neuraco for catching the hilarious typo of peer as "pier" that has been in our repo for about 7 months now :0 ! |
6a5dada to
f736ffc
Compare
CougarTasker
left a comment
There was a problem hiding this comment.
LGTM, but I am biased @muneebneura/ @damonhayhurst-neuraco give this a scan too
damonhayhurst-neuraco
left a comment
There was a problem hiding this comment.
LGTM w/ comment