Open
Conversation
Contributor
|
✅ PR source branch is valid
|
8a58ada to
baff108
Compare
Contributor
|
We have a ticket this sprint to discuss how to handle delta joint/pose actions. Until then I think this and similar datasets will need to be on hold. |
3982231 to
e37ad91
Compare
baff108 to
03f56c9
Compare
Contributor
Author
|
Closing for now until we figure out what to do with action deltas. |
8cb2e4e to
b43ef72
Compare
Contributor
Author
|
@ypang-neuraco Can you have a look at this again? |
ypang-neuraco
requested changes
Apr 7, 2026
|
|
||
| output_dataset: | ||
| name: viola_tfds | ||
| tags: [franka, kitchen, viola, imitation, tfds] |
Comment on lines
+113
to
+114
| - name: action_world_vector | ||
| source_name: world_vector |
Contributor
There was a problem hiding this comment.
what's the world vector?
b43ef72 to
2d7fe10
Compare
Contributor
Author
|
Addressed inline review comments:
|
2d7fe10 to
534e762
Compare
534e762 to
cfd689d
Compare
Contributor
|
Discussed offline, we need to change the importer to enable importing ee pose position and orientation from different source names. |
Contributor
|
LGTM other than the JOINT_TARGET_POSITIONS which will need to be updated once we enable importing ee pose position and orientation from different source names |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Items