Skip to content

feat: add austin viola dataset#419

Open
aditya-neuraco wants to merge 1 commit intomainfrom
feat/add-austin-viola-dataset
Open

feat: add austin viola dataset#419
aditya-neuraco wants to merge 1 commit intomainfrom
feat/add-austin-viola-dataset

Conversation

@aditya-neuraco
Copy link
Copy Markdown
Contributor

Features

Items

@aditya-neuraco aditya-neuraco self-assigned this Feb 18, 2026
@aditya-neuraco aditya-neuraco added the version:patch non-breaking bug fixes; no input/output changes (except defaults) label Feb 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 18, 2026

PR source branch is valid

  • Source: feat/add-austin-viola-dataset
  • Target: develop

@aditya-neuraco aditya-neuraco force-pushed the feat/add-austin-viola-dataset branch from 8a58ada to baff108 Compare February 18, 2026 14:26
@ypang-neuraco
Copy link
Copy Markdown
Contributor

We have a ticket this sprint to discuss how to handle delta joint/pose actions. Until then I think this and similar datasets will need to be on hold.

@stepjam stepjam force-pushed the develop branch 3 times, most recently from 3982231 to e37ad91 Compare March 5, 2026 10:49
@stepjam stepjam deleted the branch main March 5, 2026 16:19
@stepjam stepjam closed this Mar 5, 2026
@stepjam stepjam reopened this Mar 5, 2026
@stepjam stepjam changed the base branch from develop to main March 5, 2026 16:31
@aditya-neuraco aditya-neuraco force-pushed the feat/add-austin-viola-dataset branch from baff108 to 03f56c9 Compare March 5, 2026 20:48
@aditya-neuraco
Copy link
Copy Markdown
Contributor Author

Closing for now until we figure out what to do with action deltas.

@aditya-neuraco aditya-neuraco reopened this Apr 2, 2026
@aditya-neuraco aditya-neuraco force-pushed the feat/add-austin-viola-dataset branch 2 times, most recently from 8cb2e4e to b43ef72 Compare April 2, 2026 16:22
@aditya-neuraco
Copy link
Copy Markdown
Contributor Author

@ypang-neuraco Can you have a look at this again?

Comment thread neuracore/importer/config/austin_viola.yaml Outdated
Comment thread neuracore/importer/config/austin_viola.yaml Outdated

output_dataset:
name: viola_tfds
tags: [franka, kitchen, viola, imitation, tfds]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove tfds

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

Comment on lines +113 to +114
- name: action_world_vector
source_name: world_vector
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the world vector?

Comment thread neuracore/importer/config/austin_viola.yaml Outdated
Comment thread neuracore/importer/config/austin_viola.yaml Outdated
@aditya-neuraco aditya-neuraco force-pushed the feat/add-austin-viola-dataset branch from b43ef72 to 2d7fe10 Compare April 10, 2026 11:12
@aditya-neuraco
Copy link
Copy Markdown
Contributor Author

Addressed inline review comments:

  • name: removed tfds suffix → viola
  • description: updated to describe dataset content
  • JOINT_POSITIONS indices: removed explicit indices (auto-increment)
  • action.world_vector: this is a 3-D normalised EE position delta clamped to [-1, 1]. Together with rotation_delta (3-D axis-angle orientation delta in radians) it forms the 6-D EE delta action.
  • CUSTOM_1D → JOINT_TARGET_POSITIONS: converted using the mutex format pattern. One difference from mutex: VIOLA stores world_vector and rotation_delta as separate TFDS dict fields rather than a single flat vector, so currently only world_vector is wired into the mapping via source_name. Happy to also wire in rotation_delta if there's a preferred way to concatenate separate dict fields for the EE pose input.
  • terminate_episode: removed — will revisit once reward logging is in.

@aditya-neuraco aditya-neuraco force-pushed the feat/add-austin-viola-dataset branch from 2d7fe10 to 534e762 Compare April 10, 2026 12:35
@aditya-neuraco aditya-neuraco force-pushed the feat/add-austin-viola-dataset branch from 534e762 to cfd689d Compare April 10, 2026 12:40
@ypang-neuraco
Copy link
Copy Markdown
Contributor

Discussed offline, we need to change the importer to enable importing ee pose position and orientation from different source names.
https://neuracore.atlassian.net/browse/NCRL-467

@ypang-neuraco
Copy link
Copy Markdown
Contributor

LGTM other than the JOINT_TARGET_POSITIONS which will need to be updated once we enable importing ee pose position and orientation from different source names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch non-breaking bug fixes; no input/output changes (except defaults)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants