-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add model construction docs #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
b165ff1
feat: merge data daemon (#378)
muneebneura 8e3a9da
fix: renaming of uploader to importer (#379)
sdas-neuraco b71ef99
fix: training run names (#380)
sdas-neuraco 67fc41b
fix: auto start daemon (#381)
muneebneura 2380729
docs: update importer docs (#384)
ypang-neuraco debdf4a
fix: add back pi0 test and fix the patching (#356)
kwangneuraco 3be44e7
feat: improved error for sync-recording (#382)
sdas-neuraco 67a232f
feat: add DROID dataset (#373)
ypang-neuraco e12549b
feat: check duplicate training name (#386)
sdas-neuraco bf300be
fix: data type limit in ring buffer chunk headers (#387)
muneebneura b204052
feat: change discord badge (#389)
kwangneuraco ee9d251
fix: move dataset cache defaults to core constants (#392)
sdas-neuraco 3b8ea95
fix: rename environment variable doc and update links (#393)
sdas-neuraco 52611d7
fix: impl path retrieving helper functions (#394)
StevenJacobs61 9c84b35
fix: remove unused importer logging helper and state enum (#395)
sdas-neuraco c3f7e9c
feat: add local training metadata for local runs (#397)
sdas-neuraco 1d9a947
fix: missing frames in encoding (#388)
favour-neuraco c2de774
fix: removed data type content mapping (#401)
muneebneura ead5b49
feat: joint position from ik (#366)
ypang-neuraco 4cbe1cd
fix: Update README to remove main branch note (#402)
sdas-neuraco 41c5b1b
fix: added codec context options to lossless vidoes (#404)
mark-neuracore 327cd06
fix: disk encoder buffer orphaned frames (#403)
mark-neuracore b1e8984
feat: add model construction documentation
sdas-neuraco 046736e
fix: fixed zmq socket race condition with a single send thread (#406)
mark-neuracore 3b678ba
fix: improve integration test robustness (#411)
ypang-neuraco 0170bd0
feat: add neuracore versions to nc.zip (#409)
sdas-neuraco 55f5f84
feat: add model construction documentation
sdas-neuraco be770d7
Merge branch 'feat/add-model-docs' of https://github.com/NeuracoreAI/…
sdas-neuraco aa884db
fix: update
sdas-neuraco 2ee7b35
fix: update
sdas-neuraco d77f2ea
fix: use shared event loop (#408)
mark-neuracore e226189
fix: ensured channel states (#398)
StevenJacobs61 2158cab
fix: updated trace status (#413)
StevenJacobs61 232aedb
feat: harden CLI launch lifecycle and config parsing (#410)
favour-neuraco b846563
fix: cli typing error (#414)
sdas-neuraco 53d99f3
fix: created retry uploading status (#415)
StevenJacobs61 ced7129
fix: update images
sdas-neuraco ca89d5b
fix: highlighting
sdas-neuraco e72620b
fix: correct indentation in nyu franka play config (#417)
aditya-neuraco 09217c9
feat: added metadata editing methods (#416)
CougarTasker b83b9e3
fix: typo
sdas-neuraco 5d640ef
chore: rename example view dataset and code cleaning (#423)
gtiboni-neuraco 13dd73a
feat: add tfds dataformat import and combine with rlds, add bridge v2…
kwangneuraco 9ef31aa
fix: fixed data daemon race condition on concurrent logging api calls…
mark-neuracore 8c1a815
fix: add json and video sources with correct the event loop (#407)
mark-neuracore a562bbd
fix: update documentation link in README (#424)
gtiboni-neuraco 6af84d7
fix: implemented 2 phase stop recording (#425)
StevenJacobs61 fb39f26
feat: add rich hander to logging for indented colorful logs (#426)
aditya-neuraco 371c186
feat: add lerobot dataset importer test file (#422)
kwangneuraco 43b507e
feat: add mobile aloha dataset (#427)
ypang-neuraco 4cf3251
fix: removed redundant state (#429)
StevenJacobs61 5658615
feat: add docs on examples and delete the no_robot (#433)
kwangneuraco addf9dd
feat: save requirement.txt in the right folder when creating nc (#432)
kwangneuraco 5626aea
fix: broken permissions on forked repository (#436)
CougarTasker fbd5f08
feat: add pi0 to the integration test (#437)
kwangneuraco d21f050
chore: comments and import improved in bigym example (#438)
gtiboni-neuraco ee1189d
feat: switch to bucket logging (#420)
sdas-neuraco 8068701
fix: WIP
sdas-neuraco 483f7b7
fix: WIP
sdas-neuraco d1feb4d
Merge branch 'develop' into feat/add-model-docs
sdas-neuraco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,53 +1,96 @@ | ||
| name: Check PR Source Branch | ||
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_target: | ||
| branches: | ||
| - main | ||
| - develop | ||
| types: [opened, synchronize, reopened, edited] | ||
|
|
||
| jobs: | ||
| check-source-branch: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| pull-requests: write | ||
| issues: write | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Check if PR is from dev/develop branch | ||
| - name: Validate PR source vs target | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const pr = context.payload.pull_request; | ||
| const sourceBranch = pr.head.ref; | ||
| const targetBranch = pr.base.ref; | ||
| const allowedBranches = ['develop']; | ||
|
|
||
| const allowedSourceForMain = ['develop']; | ||
| const marker = '<!-- pr-source-branch-check -->'; | ||
|
|
||
| console.log(`PR #${pr.number}: ${sourceBranch} -> ${targetBranch}`); | ||
|
|
||
| if (targetBranch === 'main' && !allowedBranches.includes(sourceBranch)) { | ||
| const errorMessage = `❌ **Invalid PR Source Branch** | ||
| // Helper: create/update a single bot comment instead of spamming | ||
| async function upsertComment(body) { | ||
| const { data: comments } = await github.rest.issues.listComments({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: pr.number, | ||
| per_page: 100, | ||
| }); | ||
|
|
||
| PRs to \`main\` can only come from the \`develop\` branch. | ||
| const existing = comments.find(c => | ||
| c.user?.type === 'Bot' && | ||
| typeof c.body === 'string' && | ||
| c.body.includes(marker) | ||
| ); | ||
|
|
||
| **Current PR:** | ||
| - Source: \`${sourceBranch}\` | ||
| - Target: \`${targetBranch}\` | ||
| if (existing) { | ||
| await github.rest.issues.updateComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| comment_id: existing.id, | ||
| body, | ||
| }); | ||
| } else { | ||
| await github.rest.issues.createComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: pr.number, | ||
| body, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| **Required workflow:** | ||
| 1. Merge your feature branch into \`develop\` | ||
| 2. Once ready for release, create a PR from \`develop\` to \`main\` | ||
| // RULE: Only enforce when targeting main | ||
| if (targetBranch === 'main' && !allowedSourceForMain.includes(sourceBranch)) { | ||
| const errorMessage = `${marker} | ||
| ❌ **Invalid PR Source Branch forcing to main** | ||
|
|
||
| Please close this PR and follow the correct branching workflow.`; | ||
| PRs to \`main\` can only come from the \`develop\` branch. | ||
|
|
||
| core.setFailed(errorMessage); | ||
| **Current PR:** | ||
| - Source: \`${sourceBranch}\` | ||
| - Target: \`${targetBranch}\` | ||
|
|
||
| // Post comment on PR | ||
| await github.rest.issues.createComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: pr.number, | ||
| body: errorMessage | ||
| }); | ||
| } else { | ||
| console.log('✅ Source branch is valid'); | ||
| core.summary.addRaw(`✅ PR source branch \`${sourceBranch}\` is allowed for target \`${targetBranch}\``); | ||
| await core.summary.write(); | ||
| **Required workflow:** | ||
| 1. Merge your feature branch into \`develop\` | ||
| 2. Once ready for release, create a PR from \`develop\` to \`main\``; | ||
|
|
||
| await upsertComment(errorMessage); | ||
| core.setFailed(errorMessage); | ||
| return; | ||
| } | ||
|
|
||
| // If not targeting main, or source is develop, it's valid | ||
| const okMessage = `${marker} | ||
| ✅ **PR source branch is valid** | ||
|
|
||
| - Source: \`${sourceBranch}\` | ||
| - Target: \`${targetBranch}\``; | ||
|
|
||
| // Optional: update comment to green status when user retargets to develop | ||
| await upsertComment(okMessage); | ||
|
|
||
| core.summary.addRaw(okMessage); | ||
| await core.summary.write(); | ||
| console.log('✅ Source branch is valid'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both Franka and Kuka has 7 Dofs, so using Franka here is not appropriate, using UR-5 is good because it has 6 DoF