Skip to content

fix: shuffle demos before slicing to get different demos#47

Open
gtiboni-neuraco wants to merge 1 commit intomasterfrom
fix/shuffle-demos
Open

fix: shuffle demos before slicing to get different demos#47
gtiboni-neuraco wants to merge 1 commit intomasterfrom
fix/shuffle-demos

Conversation

@gtiboni-neuraco
Copy link

Features

  • np.random.shuffle(files) now happen before files = files[:amount]
  • this allows to actually sample different demos every time when calling get_demos(amount=1) multiple times.

Clarification

  • Was there an intended reason as to why get_demos(amount=1) should really give the same demo over and over when called multiple times?

Copy link

@sdas-neuraco sdas-neuraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants