Integrate L1SLOAD to the devnet script#61
Conversation
|
@claude please review |
There was a problem hiding this comment.
Pull request overview
This PR integrates L1SLOAD (RIP-7728) support into the Surge devnet deployment. L1SLOAD is a precompile that allows L2 contracts to read L1 storage, and this change configures all necessary components (Nethermind, Raiko, chainspec) to support it. The PR description includes thorough E2E verification results demonstrating both direct and indirect L1SLOAD calls working end-to-end.
Changes:
- Switches Nethermind and Raiko images to local builds (
nethermind-local:latest,raiko-local:latest) that include L1SLOAD support, with correspondingpull_policy: neverand enhancedRUST_LOGfor L1SLOAD-related crates - Adds
rip7728TransitionTimestamp = "0x0"to the chainspec generation pipeline and passes--Surge.L1EthApiEndpointto Nethermind for L1SLOAD precompile initialization - Sets
PROOF_POLLING_INTERVAL=3sin devnet config for faster proof polling
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.env.devnet |
Switches to local Docker images for Nethermind and Raiko; sets proof polling interval |
docker-compose.yml |
Sets pull_policy: never for local images; adds L1SLOAD crate log targets to Raiko |
deploy-surge-full.sh |
Adds RIP-7728 transition timestamp to chainspec; passes L1 endpoint to genesis hash extraction container |
script/start-nethermind.sh |
Passes --Surge.L1EthApiEndpoint flag for L1SLOAD support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…load # Conflicts: # .env.devnet # deploy-surge-full.sh # script/start-nethermind.sh
… latest surge-raiko
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
@claude review and be concise! |
|
@claude review |
|
Claude finished @smartprogrammer93's task in 1m 13s —— View job Code Review
The PR integrates L1SLOAD (RIP-7728) support into the devnet deployment. The changes are focused and correct. A few observations:
This is a significant refactor of teardown logic:
Overall: The L1SLOAD-specific changes ( |
The refactor accidentally dropped the mode_choice conditional, causing docker compose output to always be suppressed even in debug mode.
|
@claude review again and be concise! |
|
Claude finished @jmadibekov's task in 49s —— View job Code Review
Overall: Changes are focused, correct, and minimal. The |
Integrates L1SLOAD (RIP-7728) into the devnet deployment scripts.
master-334488b), taiko-client (surge-shasta-0933c0f9), raiko (sha-2c34626)rip7728TransitionTimestamp = "0x0"to generated chainspec (enables L1SLOAD from genesis)--Surge.L1EthApiEndpoint+--add-hostto genesis hash container so NMC can initialize L1SLOADE2E verification on devnet
Both direct and indirect L1SLOAD calls were tested on fresh devnets and proved successfully.
Test scripts
Direct L1SLOAD call (EOA -> precompile)
Indirect L1SLOAD call (EOA -> L1Reader contract -> precompile)
Cross references