feat: Sedge<>Aztec integration by khalifaa55 · Pull Request #539 · NethermindEth/sedge

khalifaa55 · 2025-12-17T18:53:26Z

#383
#469

Changes:

Add integration for Aztec Sequencers
Add integration for Aztec Full Node

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update
Code style update (formatting, renaming)
Refactoring (no functional changes, no api changes)
Build related changes
Other (please describe):

Testing

Requires testing

Yes
No

In case you checked yes, did you write tests?

Yes
No

codecov-commenter · 2025-12-19T01:35:07Z

Codecov Report

❌ Patch coverage is 70.58824% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.28%. Comparing base (6be63bd) to head (e5831f1).

Files with missing lines	Patch %	Lines
cli/cli.go	54.11%	25 Missing and 14 partials ⚠️
cli/generate.go	80.24%	9 Missing and 7 partials ⚠️
cli/actions/generation.go	0.00%	7 Missing and 1 partial ⚠️
internal/pkg/clients/types.go	0.00%	6 Missing ⚠️
cli/sub_gen.go	91.11%	2 Missing and 2 partials ⚠️
internal/pkg/generate/types.go	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #539      +/-   ##
===========================================
+ Coverage    23.69%   24.28%   +0.58%     
===========================================
  Files          121      121              
  Lines        19671    19922     +251     
===========================================
+ Hits          4662     4838     +176     
- Misses       14472    14522      +50     
- Partials       537      562      +25

Flag	Coverage Δ
unittests	`24.28% <70.58%> (+0.58%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

stdevMac

We need to add this as well
https://docs.aztec.network/network/setup/sequencer_management#step-4-configure-environment-variables

When using nethermind

stdevMac · 2026-01-13T10:01:44Z

+	cmd.Flags().StringVarP(&flags.executionApiUrl, "execution-api-url", "", "", "Set execution api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")
+	cmd.Flags().StringVarP(&flags.consensusApiUrl, "consensus-url", "", "", "Set consensus api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")


Hardcoded values here for optimism, change to aztec

This one is still missing.

, and only create optimism nodes.

We need to update this description to aztec

stdevMac · 2026-01-13T10:09:57Z

+# --- Aztec Node configuration ---
+AZTEC_IMAGE_VERSION={{.AztecImage}}
+AZTEC_DATA_DIRECTORY={{.AztecDataDir}}
+AZTEC_KEYSTORE_PATH={{.AztecSequencerKeystorePath}}


If set on full node, this shouldn't be added

smth like this:

{{- if eq .AztecNodeType "sequencer" }} - ${AZTEC_KEYSTORE_PATH}:/var/lib/keystore {{- end }}

This is still not done, AZTEC_KEYSTORE_PATH is showing empty when we are running a full-node

stdevMac · 2026-01-13T10:38:26Z

+      ETHEREUM_HOSTS: ${AZTEC_ETHEREUM_HOSTS}
+      L1_CONSENSUS_HOST_URLS: ${AZTEC_L1_CONSENSUS_HOST_URLS}
+{{- if eq .AztecNodeType "sequencer" }}
+      KEY_STORE_DIRECTORY: /var/lib/keystore


we need to copy the keystore file inside the folder of sedge, because we are using json file when setting the node, and set up this:

AZTEC_KEYSTORE_PATH=/root/.aztec/keystore/key1.json

stdevMac · 2026-01-22T08:45:18Z

+	cmd.Flags().StringArrayVar(&flags.aztecExtraFlags, "aztec-extra-flag", []string{}, "Additional flag to configure the Aztec node service in the generated docker-compose script. Example: 'sedge generate aztec --aztec-extra-flag \"p2p.maxPeers=200\" --aztec-extra-flag \"txPool.maxSize=10000\"'")
+	cmd.Flags().StringVarP(&flags.consensusName, "consensus", "c", "", "Consensus engine client, e.g. teku, lodestar, prysm, lighthouse, Nimbus. Additionally, you can use this syntax '<CLIENT>:<DOCKER_IMAGE>' to override the docker image used for the client. If you want to use the default docker image, just use the client name")
+	cmd.Flags().StringVarP(&flags.executionName, "execution", "e", "", "Execution engine client, e.g. geth, nethermind, besu, erigon. Additionally, you can use this syntax '<CLIENT>:<DOCKER_IMAGE>' to override the docker image used for the client. If you want to use the default docker image, just use the client name")
+	cmd.Flags().StringVarP(&flags.executionApiUrl, "execution-api-url", "", "", "Set execution api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")


Hardcoded values here for optimism, change to aztec

stdevMac · 2026-01-22T08:45:22Z

+	// Bind flags
+	cmd.Flags().StringVar(&flags.aztecType, "type", aztecNodeTypeFullNode, fmt.Sprintf("Aztec node type. One of: %s,%s", aztecNodeTypeFullNode, aztecNodeTypeSequencer))
+	cmd.Flags().StringVar(&flags.aztecSequencerKeystorePath, "aztec-keystore-path", "", "Path to Aztec sequencer keystore.json file (required when --type sequencer). The keystore must be generated using 'aztec validator-keys new' command. See https://docs.aztec.network/network/setup/sequencer_management for details.")
+	cmd.Flags().StringVar(&flags.aztecP2pIp, "aztec-p2p-ip", "", "P2P IP address for Aztec sequencer. This is the IP address that other nodes will use to connect to this sequencer.")


Since this is only 1 node, see if possible to show the default image here.

This is already done here

stdevMac · 2026-01-22T08:46:05Z

+	cmd.Flags().StringVarP(&flags.executionApiUrl, "execution-api-url", "", "", "Set execution api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")
+	cmd.Flags().StringVarP(&flags.consensusApiUrl, "consensus-url", "", "", "Set consensus api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")


This still need to be fixed, look at the descriptions, it say at the create optimism nodes.

stdevMac · 2026-01-22T08:54:37Z

+	cmd.Flags().StringVarP(&flags.executionApiUrl, "execution-api-url", "", "", "Set execution api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")
+	cmd.Flags().StringVarP(&flags.consensusApiUrl, "consensus-url", "", "", "Set consensus api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")


This one is still missing.

, and only create optimism nodes.

We need to update this description to aztec

stdevMac · 2026-01-22T08:56:29Z

+# --- Aztec Node configuration ---
+AZTEC_IMAGE_VERSION={{.AztecImage}}
+AZTEC_DATA_DIRECTORY={{.AztecDataDir}}
+AZTEC_KEYSTORE_PATH={{.AztecSequencerKeystorePath}}


This is still not done, AZTEC_KEYSTORE_PATH is showing empty when we are running a full-node

khalifaa55 · 2026-01-22T11:35:44Z

@stdevMac changes addressed for the following:

Aztec Keystore condition: 7756a21
Optimism hard-coded values: 4238354
Regarding aztec default image you can find it in a previous commit here:

sedge/cli/sub_gen.go

Line 419 in 4238354

cmd.Flags().StringVar(&flags.aztecName, "aztec-image", configs.ClientImages.Aztec.Aztec.String(), "Aztec docker image.")

feat: Aztec sequencers integration

568799b

khalifaa55 self-assigned this Dec 17, 2025

khalifaa55 added 5 commits December 18, 2025 18:59

feat: add templates

45d2176

feat: add generate aztec sequencer command

9a17a0a

chore: update changelog

f13ef8b

fix: generation script

451868c

fix: add keystore test data

14c167d

khalifaa55 added 2 commits December 23, 2025 19:05

feat: add cli command ans tests

8eb2341

fix: format

8b7099d

khalifaa55 marked this pull request as ready for review December 23, 2025 17:07

khalifaa55 added 3 commits December 23, 2025 19:39

feat: add extra flags option

9b7b5f0

fix: update formatting

5be9860

feat: add aztec full node integration

03e600b

khalifaa55 changed the title ~~feat: Aztec sequencers integration~~ feat: Sedge<>Aztec integration Jan 8, 2026

khalifaa55 added 5 commits January 8, 2026 15:23

chore: update changelog

2acad9f

fix: remove old aztec sequencer variables

52c0533

fix: args test

147f81d

refac: rename aztec full node value

fef9544

fix: update e2e test

09a0f0a

stdevMac reviewed Jan 13, 2026

View reviewed changes

khalifaa55 added 4 commits January 13, 2026 16:27

refac: address coments

452a55b

fix: adjust formatting

69b12a7

fix: execution engine name

14b3fff

refac: aztec image logic

e62e01c

stdevMac reviewed Jan 22, 2026

View reviewed changes

khalifaa55 added 2 commits January 22, 2026 13:23

fix: update aztec template

7756a21

fix: remove optimism from aztec cli

4238354

khalifaa55 added 3 commits January 22, 2026 13:40

fix: update tests

0166bd3

refac: p2p ip required for both fullnode and sequencers

b20d40c

refac: remove extra cli prompt for aztec

e5831f1

stdevMac approved these changes Jan 30, 2026

View reviewed changes

Merge branch 'develop' into feat/aztec-sequencers

69d9dcc

khalifaa55 closed this Jan 30, 2026

		cmd.Flags().StringVarP(&flags.executionApiUrl, "execution-api-url", "", "", "Set execution api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")
		cmd.Flags().StringVarP(&flags.consensusApiUrl, "consensus-url", "", "", "Set consensus api url. If Set, will omit the creation of execution and beacon nodes, and only create optimism nodes.")

Conversation

khalifaa55 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Types of changes

Testing

Uh oh!

codecov-commenter commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

stdevMac left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khalifaa55 commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

khalifaa55 commented Dec 17, 2025 •

edited

Loading

codecov-commenter commented Dec 19, 2025 •

edited

Loading