Skip to content

jsonrpc: Add generic-based dispatch for RPC handler calls #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brbrr wants to merge 6 commits into
base: try/sonic-json
Choose a base branch
from

extract guestimatedTagLen into a separate variable for clarity

e01fcbc
Select commit
Loading
Failed to load commit list.
Open

jsonrpc: Add generic-based dispatch for RPC handler calls #3642

extract guestimatedTagLen into a separate variable for clarity
e01fcbc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 15, 2026 in 1s

74.70% (target 70.00%)

View this Pull Request on Codecov

74.70% (target 70.00%)

Details

Codecov Report

❌ Patch coverage is 35.45082% with 315 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.70%. Comparing base (553042a) to head (e01fcbc).

Files with missing lines Patch % Lines
rpc/v10/register.go 2.75% 105 Missing and 1 partial ⚠️
rpc/v8/register.go 11.32% 93 Missing and 1 partial ⚠️
rpc/v9/register.go 13.76% 93 Missing and 1 partial ⚠️
jsonrpc/register.go 88.23% 8 Missing and 8 partials ⚠️
jsonrpc/server.go 73.33% 2 Missing and 2 partials ⚠️
rpc/handlers.go 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           try/sonic-json    #3642      +/-   ##
==================================================
- Coverage           76.00%   74.70%   -1.30%     
==================================================
  Files                 388      392       +4     
  Lines               35000    34489     -511     
==================================================
- Hits                26600    25766     -834     
- Misses               6530     6841     +311     
- Partials             1870     1882      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov