feat(cmd): trie verifier in the cmd #3338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (56.53%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## maksym/doctor-cmd #3338 +/- ##
=====================================================
- Coverage 76.04% 75.88% -0.16%
=====================================================
Files 349 350 +1
Lines 32864 33193 +329
=====================================================
+ Hits 24992 25190 +198
- Misses 6085 6187 +102
- Partials 1787 1816 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodrodros
reviewed
Dec 22, 2025
| Height uint8 | ||
| } | ||
|
|
||
| func (v *TrieVerifier) Run(ctx context.Context, cfg Config) error { |
Collaborator
There was a problem hiding this comment.
I'm not sure I understand the need of the Config interface. What's the rationale behind it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the first verification command: trie verifier.
To use it, hit
juno verify trie --db-path <path>. When no other flag is specified, this verifier runs with default config and scans all the contract, class and contracts storage tries residing in the DB. If the user wants to scan a particular group of tries, they can pass the--typeflag, pointing to which tries should be verified.For example:
juno verify trie --db-path <path> --type contract-storage --type classwill omit the contract trie verification and will verify class and contract storage tries only.