Skip to content

Conversation

@MaksymMalicki
Copy link
Contributor

@MaksymMalicki MaksymMalicki commented Nov 19, 2025

This PR should be reviewed after #3277 . It aims to:

  • Move the State and Trie interfaces from commonstate and commontrie packages to core package and rename them to CommonState and CommonTrie. This way the circular imports are omitted and there is no naming clash.
  • Use the CommonState and CommonTrie in Juno. Right now both old and new implementations of State and Trie use these interfaces. It is possible to utilise the new interfaces in Juno, but always feed the old implementations to them. The CMD flag, specifying which set of implementations to use will be introduced in the next PR.
  • Implement the missing CompiledClassHash() and CompiledClassHashV2() methods for the new State
  • Rename MockStateHistoryReader and all its methods to MockCommonState

The next PR to review: #3187

MaksymMalicki and others added 30 commits July 31, 2025 00:08
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 61.42857% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.30%. Comparing base (7120787) to head (f1e4fde).

Files with missing lines Patch % Lines
core/state/state.go 0.00% 12 Missing ⚠️
core/state/history.go 42.85% 4 Missing ⚠️
core/pending_state.go 0.00% 3 Missing ⚠️
core/state/statefactory/state_factory.go 0.00% 3 Missing ⚠️
core/state_snapshot.go 0.00% 3 Missing ⚠️
core/state.go 66.66% 1 Missing ⚠️
sync/sync.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           maksym/rawdb    #3278      +/-   ##
================================================
+ Coverage         76.10%   76.30%   +0.19%     
================================================
  Files               328      327       -1     
  Lines             32393    32335      -58     
================================================
+ Hits              24654    24673      +19     
+ Misses             5957     5889      -68     
+ Partials           1782     1773       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MaksymMalicki and others added 3 commits November 19, 2025 22:08
Signed-off-by: MaksymMalicki <81577596+MaksymMalicki@users.noreply.github.com>
@MaksymMalicki MaksymMalicki changed the base branch from maksym/rawdb to maksym/rawdb-clean November 20, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants