feat: docker image signing#155
Open
0xDones wants to merge 4 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add opt-out JFrog Evidence signing to the reusable jfrog build workflow: - new inputs sign_image, signing_key_alias, predicate_type - new secrets infisical_identity_id, infisical_project_id - push full commit SHA as an immutable tag (signed package-version) - resolve manifest digest, fetch key from Infisical, generate provenance predicate, run jf evd create, emit job summary Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Default signing key fetched from Infisical path /github/workflows/shared/github-workflows, secret DOCKER_IMAGE_SIGNING_PRIVATE_KEY. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - name: Fetch signing key from Infisical | ||
| if: ${{ inputs.push && inputs.sign_image }} | ||
| uses: NethermindEth/github-workflows/get_infisical_secrets@main |
There was a problem hiding this comment.
Pull request overview
Adds first-class Docker image signing to the reusable JFrog build/push workflow using JFrog Evidence, backed by an ECDSA P-256 key fetched from Infisical, and documents how consumers verify/rotate keys.
Changes:
- Extend
.github/workflows/docker-build-push-jfrog.yamlwith signing inputs/secrets and post-push steps to resolve digest, generate a predicate, and create Evidence. - Update docker examples/docs to describe signing behavior, required secrets, offline verification, and key rotation.
- Add a signing design spec under
docs/superpowers/specs/.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
keys/README.md |
Documents signing key intent/location/usage. |
examples/docker/README.md |
Adds signing usage, verification, and rotation instructions. |
examples/docker/build-push-jfrog-complete.yml |
Demonstrates how to enable/configure signing and pass Infisical secrets. |
docs/superpowers/specs/2026-05-29-jfrog-evidence-image-signing-design.md |
Design/architecture rationale and acceptance-criteria mapping. |
.github/workflows/docker-build-push-jfrog.yaml |
Implements digest resolution + Evidence predicate generation + signing steps in reusable workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+213
to
+215
| image_tags: | | ||
| ${{ github.sha }} | ||
| ${{ inputs.additional_tags }} |
Comment on lines
+244
to
+246
| - name: Fetch signing key from Infisical | ||
| if: ${{ inputs.push && inputs.sign_image }} | ||
| uses: NethermindEth/github-workflows/get_infisical_secrets@main |
Comment on lines
+3
to
+6
| ## jfrog-evidence-image-signing.pub | ||
|
|
||
| ECDSA P-256 public key for verifying JFrog Evidence on Docker images signed by | ||
| `.github/workflows/docker-build-push-jfrog.yaml`. |
Comment on lines
+105
to
+106
| Public key: [`keys/jfrog-evidence-image-signing.pub`](../../keys/jfrog-evidence-image-signing.pub). | ||
|
|
Comment on lines
+98
to
+103
| jf evd verify \ | ||
| --package-name <image> \ | ||
| --package-version <git-sha> \ | ||
| --package-repo-name <docker-repo> \ | ||
| --public-keys ./jfrog-evidence-image-signing.pub | ||
| ``` |
Comment on lines
+288
to
+304
| run: | | ||
| set -euo pipefail | ||
| if [[ -n "$REPO_NAME_INPUT" ]]; then | ||
| REPO_NAME="$REPO_NAME_INPUT" | ||
| else | ||
| REPO_NAME="${GROUP_NAME_INPUT}-oci-local-dev" | ||
| fi | ||
| # IMAGE_NAME is "<repo>/<image>"; package-name is just "<image>" | ||
| PACKAGE_NAME="${IMAGE_NAME#*/}" | ||
| jf evd create \ | ||
| --package-name "$PACKAGE_NAME" \ | ||
| --package-version "$PACKAGE_VERSION" \ | ||
| --package-repo-name "$REPO_NAME" \ | ||
| --predicate ./predicate.json \ | ||
| --predicate-type "$PREDICATE_TYPE" \ | ||
| --key "$PRIVATE_KEY" \ | ||
| --key-alias "$KEY_ALIAS" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.